You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2017/10/12 17:35:24 UTC
[1/2] [lang] LANG-1358: Improve StringUtils#replace throughput
(closes #300)
Repository: commons-lang
Updated Branches:
refs/heads/master 274dbfe81 -> 04ca0852b
LANG-1358: Improve StringUtils#replace throughput (closes #300)
Motivation:
`StringUtils#replace` uses `substring` to append a String region into a
StringBuilder. This causes useless copies, as `StringBuilder#append`
can take start and end indexes.
Modification:
Use proper `StringBuilder#append` [overload](https://docs.oracle.com/javase/8/docs/api/java/lang/StringBuilder.html#append-java.lang.CharSequence-int-int-).
Result:
Based on benchmark from [JOOQ’s post](https://blog.jooq.org/2017/10/11/benchmarking-jdk-string-replace-vs-apache-commons-stringutils-replace):
Benchmark Mode Cnt Score Error Units
StringReplaceBenchmark.testFastStringReplaceLongStringOneMatch thrpt 21
7546534,219 ± 145523,962 ops/s
StringReplaceBenchmark.testStringUtilsReplaceLongStringOneMatch thrpt
21 7353512,552 ± 124498,228 ops/s
StringReplaceBenchmark.testFastStringReplaceLongStringSeveralMatches
thrpt 21 5077255,810 ± 62358,937 ops/s
StringReplaceBenchmark.testStringUtilsReplaceLongStringSeveralMatches
thrpt 21 4108357,612 ± 92909,038 ops/s
StringReplaceBenchmark.testFastStringReplaceShortStringOneMatch thrpt
21 15911221,949 ± 541064,693 ops/s
StringReplaceBenchmark.testStringUtilsReplaceShortStringOneMatch thrpt
21 10677897,475 ± 491091,973 ops/s
StringReplaceBenchmark.testFastStringReplaceShortStringSeveralMatches
thrpt 21 9271742,251 ± 220150,121 ops/s
StringReplaceBenchmark.testStringUtilsReplaceShortStringSeveralMatches
thrpt 21 6158829,188 ± 99637,607 ops/s
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/5cb98833
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/5cb98833
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/5cb98833
Branch: refs/heads/master
Commit: 5cb988334179b4f04a27c59c1e6a888db0dbfc9c
Parents: 274dbfe
Author: Stephane Landelle <sl...@gatling.io>
Authored: Thu Oct 12 10:41:53 2017 +0200
Committer: pascalschumacher <pa...@gmx.net>
Committed: Thu Oct 12 19:31:25 2017 +0200
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/StringUtils.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/5cb98833/src/main/java/org/apache/commons/lang3/StringUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java
index 4af966e..b2b6b72 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -5515,14 +5515,14 @@ public class StringUtils {
increase *= max < 0 ? 16 : max > 64 ? 64 : max;
final StringBuilder buf = new StringBuilder(text.length() + increase);
while (end != INDEX_NOT_FOUND) {
- buf.append(text.substring(start, end)).append(replacement);
+ buf.append(text, start, end).append(replacement);
start = end + replLength;
if (--max == 0) {
break;
}
end = searchText.indexOf(searchString, start);
}
- buf.append(text.substring(start));
+ buf.append(text, start, text.length());
return buf.toString();
}
[2/2] [lang] LANG-1358: Improve StringUtils#replace throughput
Posted by pa...@apache.org.
LANG-1358: Improve StringUtils#replace throughput
Add changes.xml entry
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/04ca0852
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/04ca0852
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/04ca0852
Branch: refs/heads/master
Commit: 04ca0852b99af613e7db8f65ea6136bfe409d534
Parents: 5cb9883
Author: pascalschumacher <pa...@gmx.net>
Authored: Thu Oct 12 19:35:15 2017 +0200
Committer: pascalschumacher <pa...@gmx.net>
Committed: Thu Oct 12 19:35:15 2017 +0200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/04ca0852/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index c4491ee..cf4296e 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
<body>
<release version="3.7" date="2017-MM-DD" description="New features and bug fixes. Requires Java 7.">
+ <action issue="LANG-1358" type="update" dev="pschumacher" due-to="Stephane Landelle">Improve StringUtils#replace throughput</action>
<action issue="LANG-1355" type="add" dev="ggregory" due-to="Chas Honton">TimeZone.getTimeZone() in FastDateParser causes resource contention (PR #296.)</action>
<action issue="LANG-1348" type="fix" dev="pschumacher" due-to="mbusso">StackOverflowError on TypeUtils.toString(...) for a generic return type of Enum.valueOf</action>
<action issue="LANG-1346" type="update" dev="pschumacher">Remove deprecation from RandomStringUtils</action>