You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by ve...@apache.org on 2009/08/02 00:35:39 UTC

svn commit: r799952 - in /webservices/commons/trunk/modules/axiom/modules: axiom-api/src/test/java/org/apache/axiom/om/ axiom-api/src/test/java/org/apache/axiom/om/impl/ axiom-api/src/test/java/org/apache/axiom/soap/ axiom-api/src/test/java/org/apache/...

Author: veithen
Date: Sat Aug  1 22:35:38 2009
New Revision: 799952

URL: http://svn.apache.org/viewvc?rev=799952&view=rev
Log:
Trying to reduce the number of unclosed XMLStreamReader instances created during the unit test. Hopefully this will prevent XLXP from crashing with an OutOfMemoryError...

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMNavigatorTestBase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperConformanceTestCase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperTestBase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/soap/SOAPTestCase.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/XMLFragmentStreamReaderTest.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPDecodingStreamReaderTest.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPEncodingStreamReaderTest.java
    webservices/commons/trunk/modules/axiom/modules/axiom-integration/src/test/java/org/apache/axiom/om/impl/jaxp/TransformerTest.java
    webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilderTest.java
    webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncoding2Test.java
    webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncodingTest.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java Sat Aug  1 22:35:38 2009
@@ -45,7 +45,9 @@
     }
 
     public void testParse() {
-        checkSampleXML(getSampleOMDocument(sampleXML));
+        OMDocument doc = getSampleOMDocument(sampleXML);
+        checkSampleXML(doc);
+        doc.close(false);
     }
     
     public void testSerializeAndConsume() throws XMLStreamException {
@@ -59,7 +61,11 @@
         outXML = new String(outStream.toByteArray());
 
         // again load that to another builder
-        checkSampleXML(getSampleOMDocument(outXML));
+        OMDocument omDocument2 = getSampleOMDocument(outXML);
+        checkSampleXML(omDocument2);
+        
+        omDocument.close(false);
+        omDocument2.close(false);
     }
     
     private void checkSampleXML(OMDocument document) {
@@ -92,6 +98,7 @@
         } catch (Exception ex) {
             // We expect an exception here
         }
+        document.close(false);
     }
 
     private OMDocument getSampleOMDocument(String xml) {

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java Sat Aug  1 22:35:38 2009
@@ -45,6 +45,7 @@
         }
         assertEquals("This element should contain only five children including the text ", 5,
                      counter);
+        elt.close(false);
     }
 
     /** test the remove exception behavior */
@@ -60,6 +61,7 @@
             //ok. this is what should happen
         }
 
+        elt.close(false);
     }
 
     /** test the remove exception behavior, consecutive remove calls */
@@ -79,6 +81,7 @@
             //ok if we come here :)
         }
 
+        elt.close(false);
     }
 
     /** Remove all! */
@@ -95,7 +98,7 @@
             fail("No children should remain after removing all!");
         }
 
-
+        elt.close(false);
     }
 
     /** test whether the children count reduces. */
@@ -124,6 +127,7 @@
                      firstChildrenCount - 1,
                      secondChildrenCount);
 
+        elt.close(false);
     }
 
     /** Test the element iterator */
@@ -139,6 +143,7 @@
                        ((OMNode) o).getType() == OMNode.ELEMENT_NODE);
         }
         assertEquals("This element should contain only two elements ", 2, counter);
+        elt.close(false);
     }
     
     /** Test the element iterator */
@@ -157,6 +162,7 @@
         }
         assertEquals("This element should contain only one element with the given QName ", 1,
                      counter);
+        elt.close(false);
     }
 
     public void testGetChildrenWithLocalName() {
@@ -167,6 +173,7 @@
         assertEquals(new QName(SOAP11Constants.SOAP_ENVELOPE_NAMESPACE_URI,
                 SOAP11Constants.BODY_LOCAL_NAME), child.getQName());
         assertFalse(it.hasNext());
+        elt.close(false);
     }
 
     public void testSetText() {
@@ -261,6 +268,7 @@
         assertEquals("c", c.getLocalName());
         assertSame(c, a.getNextOMSibling());
         assertSame(a, c.getPreviousOMSibling());
+        root.close(false);
     }
     
     public void testDetachWithBuild() throws Exception {
@@ -277,6 +285,7 @@
         OMNamespace ns = root.getFirstElement().findNamespace(null, "a");
         assertNotNull(ns);
         assertEquals("urn:a", ns.getNamespaceURI());
+        root.close(false);
     }
     
     /**

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMNavigatorTestBase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMNavigatorTestBase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMNavigatorTestBase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMNavigatorTestBase.java Sat Aug  1 22:35:38 2009
@@ -23,7 +23,6 @@
 import org.apache.axiom.om.OMConstants;
 import org.apache.axiom.om.OMMetaFactory;
 import org.apache.axiom.om.OMNode;
-import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.TestConstants;
 import org.apache.axiom.om.impl.OMNavigator;
 import org.apache.axiom.om.util.StAXUtils;
@@ -38,7 +37,7 @@
 public class OMNavigatorTestBase extends AbstractTestCase {
     private final OMMetaFactory omMetaFactory;
     private SOAPEnvelope envelope = null;
-    private OMXMLParserWrapper builder;
+    private StAXSOAPModelBuilder builder;
 
     public OMNavigatorTestBase(OMMetaFactory omMetaFactory) {
         this.omMetaFactory = omMetaFactory;
@@ -51,6 +50,10 @@
         envelope = (SOAPEnvelope) builder.getDocumentElement();
     }
 
+    protected void tearDown() throws Exception {
+        builder.close();
+    }
+
     public void testnavigatorFullyBuilt() throws Exception {
         assertNotNull(envelope);
         //dump the out put to a  temporary file

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperConformanceTestCase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperConformanceTestCase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperConformanceTestCase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperConformanceTestCase.java Sat Aug  1 22:35:38 2009
@@ -51,14 +51,23 @@
         InputStream in2 = getTestResource(file);
         try {
             XMLStreamReader expected = StAXUtils.createXMLStreamReader(in1);
-            // Skip to document element. Note that nextTag is not appropriate here because
-            // there could be a DTD event.
-            while (expected.next() != XMLStreamReader.START_ELEMENT) {
-                // just loop
+            try {
+                // Skip to document element. Note that nextTag is not appropriate here because
+                // there could be a DTD event.
+                while (expected.next() != XMLStreamReader.START_ELEMENT) {
+                    // just loop
+                }
+                StAXOMBuilder builder = new StAXOMBuilder(omMetaFactory.getOMFactory(),
+                        StAXUtils.createXMLStreamReader(in2));
+                try {
+                    XMLStreamReader actual = builder.getDocumentElement().getXMLStreamReader();
+                    new XMLStreamReaderComparator(new XMLFragmentStreamReader(expected), actual).compare();
+                } finally {
+                    builder.close();
+                }
+            } finally {
+                expected.close();
             }
-            XMLStreamReader actual = new StAXOMBuilder(omMetaFactory.getOMFactory(),
-                    StAXUtils.createXMLStreamReader(in2)).getDocumentElement().getXMLStreamReader();
-            new XMLStreamReaderComparator(new XMLFragmentStreamReader(expected), actual).compare();
         } finally {
             in1.close();
             in2.close();

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperTestBase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperTestBase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperTestBase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/impl/OMStAXWrapperTestBase.java Sat Aug  1 22:35:38 2009
@@ -102,8 +102,9 @@
     }
     
     public void testCommentEvent() throws Exception {
-        XMLStreamReader reader = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(),
-                "<a><!--comment text--></a>").getXMLStreamReader();
+        OMElement element = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(),
+                "<a><!--comment text--></a>");
+        XMLStreamReader reader = element.getXMLStreamReader();
         assertEquals(XMLStreamReader.START_ELEMENT, reader.next());
         assertEquals(XMLStreamReader.COMMENT, reader.next());
         assertEquals("comment text", reader.getText());
@@ -118,6 +119,7 @@
             }
         }
         assertEquals("comment text", text.toString());
+        element.close(false);
     }
     
     public void testGetElementText() throws Exception {
@@ -153,6 +155,7 @@
         assertEquals(XMLStreamReader.END_ELEMENT, stream.next());
         assertEquals(XMLStreamReader.END_ELEMENT, stream.next());
         assertEquals(XMLStreamReader.END_DOCUMENT, stream.next());
+        root.close(false);
     }
     
     public void testNonRootElementWithCaching() throws Exception {
@@ -176,6 +179,7 @@
         stream.nextTag();
         assertEquals(XMLStreamReader.START_ELEMENT, stream.getEventType());
         assertEquals("c", stream.getLocalName());
+        element.close(false);
     }
     
     private void testGetNamespaceContext(boolean cache) throws Exception {
@@ -191,6 +195,7 @@
         assertEquals("urn:ns2", context.getNamespaceURI("ns2"));
         assertEquals("urn:ns3", context.getNamespaceURI("ns3"));
         assertEquals("ns2", context.getPrefix("urn:ns2"));
+        element.close(false);
     }
     
     public void testGetNamespaceContextWithCaching() throws Exception {

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/soap/SOAPTestCase.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/soap/SOAPTestCase.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/soap/SOAPTestCase.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/soap/SOAPTestCase.java Sat Aug  1 22:35:38 2009
@@ -64,6 +64,16 @@
                         .getDocumentElement();
     }
 
+    protected void tearDown() throws Exception {
+        super.tearDown();
+        
+        soap11Envelope.close(false);
+        soap12Envelope.close(false);
+        
+        soap11EnvelopeWithParser.close(false);
+        soap12EnvelopeWithParser.close(false);
+    }
+
     protected StAXSOAPModelBuilder getSOAPBuilder(String fileName) throws Exception {
         XMLStreamReader parser = StAXUtils.createXMLStreamReader(
                 getTestResource(fileName));

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/XMLFragmentStreamReaderTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/XMLFragmentStreamReaderTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/XMLFragmentStreamReaderTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/XMLFragmentStreamReaderTest.java Sat Aug  1 22:35:38 2009
@@ -43,5 +43,7 @@
         XMLStreamReader actual = new XMLFragmentStreamReader(reader);
         new XMLStreamReaderComparator(expected, actual).compare();
         assertEquals(XMLStreamReader.END_DOCUMENT, reader.getEventType());
+        expected.close();
+        reader.close();
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPDecodingStreamReaderTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPDecodingStreamReaderTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPDecodingStreamReaderTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPDecodingStreamReaderTest.java Sat Aug  1 22:35:38 2009
@@ -48,6 +48,8 @@
         XMLStreamReaderComparator comparator = new XMLStreamReaderComparator(expected, actual);
         comparator.addPrefix("xop");
         comparator.compare();
+        expected.close();
+        actual.close();
     }
     
     public void testGetElementText() throws Exception {
@@ -60,5 +62,6 @@
         // The data is actually a JPEG image. Try to decode it to check that the data is not
         // corrupted.
         ImageIO.read(new ByteArrayInputStream(data));
+        reader.close();
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPEncodingStreamReaderTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPEncodingStreamReaderTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPEncodingStreamReaderTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/util/stax/xop/XOPEncodingStreamReaderTest.java Sat Aug  1 22:35:38 2009
@@ -51,6 +51,9 @@
         }
         XMLStreamReader actual = new XOPEncodingStreamReader(new XOPDecodingStreamReader(soapPartReader[1], new OMAttachmentAccessorMimePartProvider(attachments[1])), contentIDGenerator, OptimizationPolicy.DEFAULT);
         new XMLStreamReaderComparator(soapPartReader[0], actual).compare();
+        for (int i=0; i<2; i++) {
+            soapPartReader[i].close();
+        }
     }
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-integration/src/test/java/org/apache/axiom/om/impl/jaxp/TransformerTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-integration/src/test/java/org/apache/axiom/om/impl/jaxp/TransformerTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-integration/src/test/java/org/apache/axiom/om/impl/jaxp/TransformerTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-integration/src/test/java/org/apache/axiom/om/impl/jaxp/TransformerTest.java Sat Aug  1 22:35:38 2009
@@ -66,7 +66,8 @@
     public void testIdentity() throws Exception {
         Transformer transformer = factory.newTransformer();
         
-        OMSource omSource = new OMSource(new StAXOMBuilder(getInput()).getDocumentElement());
+        OMElement element = new StAXOMBuilder(getInput()).getDocumentElement();
+        OMSource omSource = new OMSource(element);
         OMResult omResult = new OMResult();
         transformer.transform(omSource, omResult);
         
@@ -76,6 +77,8 @@
         transformer.transform(streamSource, streamResult);
         
         assertXMLIdentical(compareXML(out.toString(), omResult.getRootElement().toString()), true);
+        
+        element.close(false);
     }
     
     /**
@@ -109,5 +112,7 @@
         OMNamespace ns = omResult.getRootElement().findNamespaceURI("p");
         assertNotNull(ns);
         assertEquals("urn:some:namespace", ns.getNamespaceURI());
+        
+        element.close(false);
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilderTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilderTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilderTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilderTest.java Sat Aug  1 22:35:38 2009
@@ -390,9 +390,9 @@
         assertTrue("SOAP 1.2 :- Text value in Time element mismatch",
                    element21.getText().trim().equals("P3M"));
 
-        XMLStreamReader sopa11Parser = StAXUtils.createXMLStreamReader(
+        XMLStreamReader soap11Parser = StAXUtils.createXMLStreamReader(
                 new StringReader(soap11Message));
-        OMXMLParserWrapper soap11Builder = new StAXSOAPModelBuilder(sopa11Parser, null);
+        OMXMLParserWrapper soap11Builder = new StAXSOAPModelBuilder(soap11Parser, null);
         SOAPEnvelope soap11Envelope = (SOAPEnvelope) soap11Builder.getDocumentElement();
 //            soap11Envelope.build();
 //            writer = XMLOutputFactory.newInstance().createXMLStreamWriter(System.out);
@@ -561,6 +561,9 @@
                            "http:www.Test.org"));
         assertTrue("SOAP 1.1 :- Test element child value mismatch",
                    childOfTestElement.getText().trim().equals("This is only a test"));
+        
+        soap12Parser.close();
+        soap11Parser.close();
     }
 
     /**
@@ -591,13 +594,17 @@
                     badEnvEnd;
             XMLStreamReader soap12Parser = StAXUtils.createXMLStreamReader(
                     new StringReader(soap12Message));
-            StAXSOAPModelBuilder soap12Builder = new StAXSOAPModelBuilder(soap12Parser, null);
-            SOAPEnvelope soap12Envelope = (SOAPEnvelope) soap12Builder.getDocumentElement();
             try {
-                soap12Envelope.getHeader();
-            } catch (OMException e) {
-                // Good, we failed.  Keep going.
-                continue;
+                StAXSOAPModelBuilder soap12Builder = new StAXSOAPModelBuilder(soap12Parser, null);
+                SOAPEnvelope soap12Envelope = (SOAPEnvelope) soap12Builder.getDocumentElement();
+                try {
+                    soap12Envelope.getHeader();
+                } catch (OMException e) {
+                    // Good, we failed.  Keep going.
+                    continue;
+                }
+            } finally {
+                soap12Parser.close();
             }
             fail("Successfully parsed bad envelope ('" + badHeaders[i] + "')");
         }
@@ -623,6 +630,7 @@
         OMElement element = soap11Builder.getDocumentElement();
         element.build();
         this.assertXMLEqual(soap11Fault, element.toString());
+        soap11Parser.close();
     }
     
     /**
@@ -661,6 +669,7 @@
         String localName = env.getSOAPBodyFirstElementLocalName();
         this.assertTrue(localName.equals("Fault"));
         this.assertTrue(!parser.isReadBody());
+        parser.close();
     }
     
     public void testFaultWithCDATA() throws Exception {
@@ -687,5 +696,6 @@
         SOAPFault fault = se.getBody().getFault();
         SOAPFaultReason reason = fault.getReason();
         assertTrue(reason.getText().equals("handleMessage throws SOAPFaultException for ThrowsSOAPFaultToClientHandlersTest"));
+        soap11Parser.close();
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncoding2Test.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncoding2Test.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncoding2Test.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncoding2Test.java Sat Aug  1 22:35:38 2009
@@ -64,5 +64,7 @@
 
         assertXMLEqual(new InputStreamReader(new ByteArrayInputStream(xml.getBytes("iso-8859-1")),"iso-8859-1"),
                 new InputStreamReader(new ByteArrayInputStream(byteOutStr.toByteArray()),"iso-8859-1"));
+        
+        builder.close();
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncodingTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncodingTest.java?rev=799952&r1=799951&r2=799952&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncodingTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/impl/llom/CharacterEncodingTest.java Sat Aug  1 22:35:38 2009
@@ -83,7 +83,7 @@
 
         assertEquals("Expected result not received.", expected, result);
 
-
+        builder.close();
     }
 
     private void runtest(String value) throws Exception {