[jira] [Commented] (SAMZA-1033) Remove import-control from checkstyle

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550637#comment-15550637 ] 

ASF GitHub Bot commented on SAMZA-1033:
---------------------------------------

GitHub user navina opened a pull request:

    https://github.com/apache/samza/pull/17

    SAMZA-1033: Remove import-control from checkstyle

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navina/samza SAMZA-1033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit b81094d240814d3d1aa568ea09c5ca4c52fb54da
Author: Navina Ramesh <nr...@linkedin.com>
Date:   2016-10-06T02:15:45Z

    SAMZA-1033: Remove import-control from checkstyle

----


> Remove import-control from checkstyle
> -------------------------------------
>
>                 Key: SAMZA-1033
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1033
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Navina Ramesh
>            Assignee: Navina Ramesh
>             Fix For: 0.12.0
>
>
> import-control.xml was added to manage dependencies across packages better. But with more and more core changes, this check is simply creating more noise. Even though, we add dependencies, we fail to remove it. So, the file grows arbitrarily large and unmanageable. Hence, removing it.
> See http://mail-archives.apache.org/mod_mbox/samza-dev/201607.mbox/browser for more details



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)