You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron Fabbri (JIRA)" <ji...@apache.org> on 2017/12/07 23:07:00 UTC
[jira] [Comment Edited] (HADOOP-13974) S3a CLI to support
list/purge of pending multipart commits
[ https://issues.apache.org/jira/browse/HADOOP-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282675#comment-16282675 ]
Aaron Fabbri edited comment on HADOOP-13974 at 12/7/17 11:06 PM:
-----------------------------------------------------------------
Attaching v4 patch.
- Reworks code after related changes were merged from HADOOP-13786.
- Fixes typos in docs mentioned by [~stevel@apache.org].
There is one "XXX" comment that needs to be removed.. I left in for discussion (I suggest makine WriteOperationHelper static methods instead of instantiating objects just to, essentially, hold on to a couple of parameters).
Another thing I'd like comments on is: Should we just remove listMultipartUploads() and use the new iterator-based listing introduced here? That would take some reworking of committer code so I've left both versions in for now.
In general want suggestions on any code deduplication I may have missed here. I tried to reuse similar code from the S3 Committer stuff but there may be some things I missed.
was (Author: fabbri):
Attaching v4 patch.
- Reworks code after related changes were merged from HADOOP-13786.
- Fixes typos in docs mentioned by [~stevel@apache.org].
There is one "XXX" comment that needs to be removed.. I left in for discussion (I suggest makine WriteOperationHelper static methods instead of instantiating objects just to, essentially, hold on to a couple of parameters).
Another thing I'd like comments on is: Should we just remove listMultipartUploads() and use the new iterator-based listing introduced here? That would take some reworking of committer code so I've left both versions in for now.
> S3a CLI to support list/purge of pending multipart commits
> ----------------------------------------------------------
>
> Key: HADOOP-13974
> URL: https://issues.apache.org/jira/browse/HADOOP-13974
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Aaron Fabbri
> Attachments: HADOOP-13974.001.patch, HADOOP-13974.002.patch, HADOOP-13974.003.patch, HADOOP-13974.004.patch
>
>
> The S3A CLI will need to be able to list and delete pending multipart commits.
> We can do the cleanup already via fs.s3a properties. The CLI will let scripts stat for outstanding data (have a different exit code) and permit batch jobs to explicitly trigger cleanups.
> This will become critical with the multipart committer, as there's a significantly higher likelihood of commits remaining outstanding.
> We may also want to be able to enumerate/cancel all pending commits in the FS tree
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org