[GitHub] [arrow] jvanstraten commented on pull request #12494: ARROW-15760: [C++] Avoid hard dependency on git in cmake (download tarballs from github instead)

[GitBox <gi...@apache.org>]

jvanstraten commented on pull request #12494:
URL: https://github.com/apache/arrow/pull/12494#issuecomment-1048788164


   Uh oh, looks like there's been some redundant, parallel work going on... See https://github.com/apache/arrow/pull/12457
   
   tl;dr: the whole setup with the ARROW_SUBSTRAIT_REPO option and such was in and of itself not very conformant to the way the rest of Arrow's build works, and the git shenanigans broke a lot more than just failure to build without git when doing inline builds. Above PR converts the entire build for Substrait to the more usual `ThirdpartyToolchain.cmake` workflow and should supersede this. AFAIK it's ready to merge.
   
   > I think the purpose of the ARROW_SUBSTRAIT_REPO variable is that the developer can quickly switch to a substrait fork with altered protobuf definitions. Introducing a checksum variable would make that less convenient.
   
   It wouldn't work without changing code (including CMake stuff) anyway, since Substrait is still too volatile for that. That said, it'd be useful to have a proper way to override dependency versions and download URL patterns using options for development purposes, which ideally would also just disable the hash check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org