You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/02/12 07:55:17 UTC
[GitHub] zeppelin pull request #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zep...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2008
[MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.apache.org in docs site
### What is this PR for?
Currently there is no link to go back to [zeppelin.apache.org](https://zeppelin.apache.org) in each docs site. It's a bit inconvenient.
e.g. In [https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/), if I click Zeppelin main logo, it keeps me staying in docs main page not the root: [zeppelin.apache.org](https://zeppelin.apache.org).
So I separated main logo in navbar to "Zeppelin" and "version". And linked [production_url](https://github.com/apache/zeppelin/blob/master/docs/_config.yml#L34) and [BASE_PATH](https://github.com/apache/zeppelin/blob/master/docs/_config.yml#L62) to each of them. Please see the below screenshot img.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2100](https://issues.apache.org/jira/browse/ZEPPELIN-2100)
### How should this be tested?
Run docs site locally under `ZEPPELIN_HOME/docs` as described in here: [Run website locally](https://github.com/apache/zeppelin/blob/master/docs/README.md#run-website-locally)
### Screenshots (if appropriate)
In [https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/),
- Before
<img width="400px" src="https://cloud.githubusercontent.com/assets/10060731/22860466/6064c964-f142-11e6-9bc1-bbd34fa42c18.png">
- After
<img width="500px" src="https://cloud.githubusercontent.com/assets/10060731/22860469/69364568-f142-11e6-963d-7b6ab33330c3.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin change/mainLogoUrlToOfficialSite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2008
----
commit 80f724cbfe9e4891205d0830a11d1644b9160a98
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-12T07:19:57Z
Set main logo url to zeppelin.apache.org not docs site
commit 335e625bf31ce797e01ec94334c83eb741037956
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-12T07:54:09Z
Fix indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2008
Thanks for your suggestion! But as you can see, currently there is no much space between the "version" and "Quick Start" menu.
<img width="964" alt="screen shot 2017-02-13 at 9 04 23 pm" src="https://cloud.githubusercontent.com/assets/10060731/22882763/0edebaac-f230-11e6-966c-98f9aa09849a.png">
So just using exist main logo and version text is more practical(?) than one more menu button to go back to root page I think. What do you think? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2008
yea not sure. what if we add a new menu next to Quick Start menu?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2008
ah, but that's not very obvious though?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2008
I'm good with either way.
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2008
@felixcheung Thanks anyway for your feedback.
Then will merge this into branch-0.7 and master if there are no comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2008: [MINOR][ZEPPELIN-2100] Enable to go back to zeppelin.a...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2008
@felixcheung Yeah agree. But I don't have better idea than this way for now. Will be appreciated if you (or anyone) can suggest :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---