You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/04 22:34:14 UTC

[GitHub] [spark] rdblue commented on issue #25955: [SPARK-29277][SQL] Add early DSv2 filter and projection pushdown

rdblue commented on issue #25955: [SPARK-29277][SQL] Add early DSv2 filter and projection pushdown
URL: https://github.com/apache/spark/pull/25955#issuecomment-538581245
 
 
   All tests are passing without calling the computeStats method before pushdown, so I'm confident that the early pushdown rule is in the right place. I'm adding back the computeStats method that will throw UnsupportedOperationException while testing to ensure that it is not incorrectly called in the future. It does not throw an exception when not testing so that user queries don't fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org