[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20981: [FEATURE] Add oneDNN support for npi: exp, square and sqrt

[GitBox <gi...@apache.org>]

bartekkuncer commented on a change in pull request #20981:
URL: https://github.com/apache/incubator-mxnet/pull/20981#discussion_r837337328



##########
File path: src/operator/nn/dnnl/dnnl_eltwise-inl.h
##########
@@ -50,17 +52,18 @@ class DNNLTanhFwd {
   std::shared_ptr<eltwise_fwd_pd_t> fwd_pd;
 };
 
-inline void DNNLTanhForward(const nnvm::NodeAttrs& attrs,
-                            const OpContext& ctx,
-                            const NDArray& input,
-                            const OpReqType& req,
-                            const NDArray& output) {
-  DNNLTanhFwd& fwd = DNNLTanhFwd::GetTanhForward(input, output);
+template <dnnl::algorithm algorithm>
+inline void DNNLEltwiseForward(const nnvm::NodeAttrs& attrs,

Review comment:
       DNNLRun function takes only 5 parameters and using template allows for sixth.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org