You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Christophe Taton (JIRA)" <ji...@apache.org> on 2013/10/11 03:26:42 UTC

[jira] [Updated] (AVRO-1385) Enum reader/writer resolution doesn't report errors

     [ https://issues.apache.org/jira/browse/AVRO-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Taton updated AVRO-1385:
-----------------------------------

    Attachment: AVRO-1385.base=a56e7f13c4fa976b7926649b058665f42850a349.20131010-182234.patch

Here is a patch with a proposed change.

> Enum reader/writer resolution doesn't report errors
> ---------------------------------------------------
>
>                 Key: AVRO-1385
>                 URL: https://issues.apache.org/jira/browse/AVRO-1385
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.5
>            Reporter: Christophe Taton
>         Attachments: AVRO-1385.base=a56e7f13c4fa976b7926649b058665f42850a349.20131010-182234.patch
>
>
> According to the specification, when a reader enum does not contain all symbols from the writer enum, an error should be signaled.
> ResolvingGrammarGenerator fails to report such errors.
> In particular, mkEnumAdjust() silently maps unknown symbols of the writers with symbols named "No match for [writer symbol]".
> https://github.com/apache/avro/blob/trunk/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L409
> Shouldn't this instead create an ErrorAction?



--
This message was sent by Atlassian JIRA
(v6.1#6144)