You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/21 03:15:04 UTC
[GitHub] [iotdb] bigreybear opened a new pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
bigreybear opened a new pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095
Clearer message for alignment conflict of template and mounted node.
Now message will carry template name and specified conflit node path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095#discussion_r810772068
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/template/TemplateManager.java
##########
@@ -175,9 +176,10 @@ public void checkTemplateCompatible(Template template, IMNode node) throws Metad
for (IMNode dNode : template.getDirectNodes()) {
if (dNode.isMeasurement()) {
throw new MetadataException(
- "Template and mounted node has different alignment: "
Review comment:
@bigreybear Hey, this PR causes the unit test `TemplateTest.testTemplateAlignment` failed. Could you do a patch to fix the test as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095#issuecomment-1046455801
[](https://coveralls.io/builds/46718928)
Coverage increased (+0.03%) to 67.795% when pulling **4d9a1514a7edc1f6c413654bac8fc32599a1186a on bigreybear:i2577** into **ba0c6ee014f3d07771f63fa1c95d64b515993f56 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095#discussion_r810772068
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/template/TemplateManager.java
##########
@@ -175,9 +176,10 @@ public void checkTemplateCompatible(Template template, IMNode node) throws Metad
for (IMNode dNode : template.getDirectNodes()) {
if (dNode.isMeasurement()) {
throw new MetadataException(
- "Template and mounted node has different alignment: "
Review comment:
Hey, this PR causes the unit test `TemplateTest.testTemplateAlignment` failed. Could you do a patch to fix the test as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] bigreybear commented on a change in pull request #5095: [IOTDB-2577]Clearer message for alignment conflict of template and mounted node
Posted by GitBox <gi...@apache.org>.
bigreybear commented on a change in pull request #5095:
URL: https://github.com/apache/iotdb/pull/5095#discussion_r810779468
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/template/TemplateManager.java
##########
@@ -175,9 +176,10 @@ public void checkTemplateCompatible(Template template, IMNode node) throws Metad
for (IMNode dNode : template.getDirectNodes()) {
if (dNode.isMeasurement()) {
throw new MetadataException(
- "Template and mounted node has different alignment: "
Review comment:
Sorry for that failure, I am putting forward another PR now
links:https://github.com/apache/iotdb/pull/5096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org