You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/22 09:50:36 UTC
[GitHub] [ignite] ptupitsyn opened a new pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
ptupitsyn opened a new pull request #7713:
URL: https://github.com/apache/ignite/pull/7713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r412865165
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
- script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ # ignite-scalar module currently doesn't build under jdk11
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,!spark-2.4,!spark,!scala -DskipTests -Dmaven.javadoc.skip=true -B -V
Review comment:
Probably the `!` needs to be escaped like this `\!`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r412865314
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
Review comment:
Let's remove it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r412903945
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
Review comment:
Fixed
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
- script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ # ignite-scalar module currently doesn't build under jdk11
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,!spark-2.4,!spark,!scala -DskipTests -Dmaven.javadoc.skip=true -B -V
before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
cache: {directories: [$HOME/.m2/repository]}
-
+
- language: csharp
mono: none
dotnet: 3.1.101
script:
- - dotnet build modules/platforms/dotnet/Apache.Ignite.DotNetCore.sln
+ - dotnet build modules/platforms/dotnet/Apache.Ignite.DotNetCore.sln
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r413042311
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
- script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ # ignite-scalar module currently doesn't build under jdk11
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,!spark-2.4,!spark,!scala -DskipTests -Dmaven.javadoc.skip=true -B -V
Review comment:
It works as it is, see build results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r412904669
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
- script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ # ignite-scalar module currently doesn't build under jdk11
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,!spark-2.4,!spark,!scala -DskipTests -Dmaven.javadoc.skip=true -B -V
Review comment:
We can also use `-` instead of `!`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7713: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7713:
URL: https://github.com/apache/ignite/pull/7713#discussion_r412865671
##########
File path: .travis.yml
##########
@@ -17,37 +17,38 @@ matrix:
include:
- language: java
os: linux
- dist: trusty
+ dist: trusty
install: skip
+ jdk: openjdk8
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,all-scala,scala -DskipTests -Dmaven.javadoc.skip=true -B -V
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ jdk: openjdk11
before_script:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
- script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ # ignite-scalar module currently doesn't build under jdk11
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples,!spark-2.4,!spark,!scala -DskipTests -Dmaven.javadoc.skip=true -B -V
before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
cache: {directories: [$HOME/.m2/repository]}
-
+
- language: csharp
mono: none
dotnet: 3.1.101
script:
- - dotnet build modules/platforms/dotnet/Apache.Ignite.DotNetCore.sln
+ - dotnet build modules/platforms/dotnet/Apache.Ignite.DotNetCore.sln
Review comment:
Missed end line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org