You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/11/03 17:54:39 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
arturobernalg opened a new pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316
Add following header:
- Accept-Patch : https://tools.ietf.org/html/rfc5789#section-3.1
- HTTP2-Settings
- A_IM : https://datatracker.ietf.org/doc/html/rfc3229
- Alt-Svc
- P3P
- Preference-Applied: https://datatracker.ietf.org/doc/html/rfc7240#page-7
- Strict-Transport-Security
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#issuecomment-977074844
@arturobernalg No one seems to be willing to approve this PR. I support it should be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742282468
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Hi @garydgregory
Fixed.
TY
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Hi @garydgregory
Fixed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742282468
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Hi @garydgregory
Fixed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742282468
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Hi @garydgregory
Fixed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg closed pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742265559
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Is there really a space?
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -162,12 +178,20 @@ private HttpHeaders() {
public static final String OVERWRITE = "Overwrite";
public static final String PRAGMA = "Pragma";
+ /**
Review comment:
I would add a blank line before a Javadoc comment.
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Is there really a space?
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -162,12 +178,20 @@ private HttpHeaders() {
public static final String OVERWRITE = "Overwrite";
public static final String PRAGMA = "Pragma";
+ /**
Review comment:
I would add a blank line before a Javadoc comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742265559
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Is there really a space?
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -162,12 +178,20 @@ private HttpHeaders() {
public static final String OVERWRITE = "Overwrite";
public static final String PRAGMA = "Pragma";
+ /**
Review comment:
I would add a blank line before a Javadoc comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on a change in pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#discussion_r742265559
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -131,6 +143,10 @@ private HttpHeaders() {
public static final String FROM = "From";
public static final String HOST = "Host";
+ /**
+ * The HTTP {@code HTTP2-Settings} header field name.
+ */
+ public static final String HTTP2_SETTINGS = " HTTP2-Settings";
Review comment:
Is there really a space?
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -162,12 +178,20 @@ private HttpHeaders() {
public static final String OVERWRITE = "Overwrite";
public static final String PRAGMA = "Pragma";
+ /**
Review comment:
I would add a blank line before a Javadoc comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #316: HTTPCORE-693 - Add HttpHeaders headers.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #316:
URL: https://github.com/apache/httpcomponents-core/pull/316#issuecomment-977152931
> @arturobernalg No one seems to be willing to approve this PR. I support it should be closed.
it seem so. Close the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org