You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/09/16 20:36:51 UTC

[GitHub] [accumulo-testing] DomGarguilo opened a new pull request, #223: Misc. improvements to randomwalk code

DomGarguilo opened a new pull request, #223:
URL: https://github.com/apache/accumulo-testing/pull/223

   This PR makes miscellaneous changes that I see as improvements to the randomwalk code.
   
   These changes should not affect the functionality of anything but rather just make improvements towards readability, simplicity, correctness etc.
   
   Some of these are issues pointed out by my IDE like typos, exceptions that can be removed, making variables final and other things.
   
   Other changes include:
   * adding resources to try-with-resources blocks
   * remove unnecessary boxing/unboxing
   * created some helper functions to reuse code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo-testing] DomGarguilo merged pull request #223: Misc. improvements to randomwalk code

Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #223:
URL: https://github.com/apache/accumulo-testing/pull/223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo-testing] DomGarguilo commented on pull request #223: Misc. improvements to randomwalk code

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #223:
URL: https://github.com/apache/accumulo-testing/pull/223#issuecomment-1250971742

   > The changes look good. I assume you tested all the rwalk modules ran as expected?
   
   Yes, from my testing everything is working as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org