[jira] [Closed] (GUACAMOLE-1799) Include Name and Version in all translation files

["Mike Jumper (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GUACAMOLE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Jumper closed GUACAMOLE-1799.
----------------------------------
    Resolution: Won't Do

This is intentional. The {{APP.NAME}} and {{APP.VERSION}} strings are supposed to only be defined in the English translation, with all other languages inheriting from that.

For example:

https://github.com/apache/guacamole-client/blob/a391dc886e10f44d2f7b54916de0db0d631ee689/guacamole/util/check-translation.py#L224-L232

These strings are defined in this way to ease overriding the name and version - a common operation for branding extensions. Doing otherwise would mean that such extensions would need to override the strings for all supported languages, would run into trouble if the application introduces a new language, etc.

If the Polish translation contains copies of these strings, those copies should be removed.

> Include Name and Version in all translation files
> -------------------------------------------------
>
>                 Key: GUACAMOLE-1799
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1799
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole
>            Reporter: Leonard Wagner
>            Priority: Trivial
>
> Only the English and Polish translation files contain the APP.NAME and APP.VERSION properties. The values of these properties are used by the login page for example.
> Currently this does not seem to be a problem because the English translation file is _somehow_ always loaded before the translation file of the language that the user requested.
> To not have to rely on this behavior and to prepare things for the Angular frontend I would like to include these properties in all translation files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)