You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/30 14:08:06 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6351: NIFI-10408 Improve error handling in LdapUserGroupProvider

exceptionfactory opened a new pull request, #6351:
URL: https://github.com/apache/nifi/pull/6351

   # Summary
   
   [NIFI-10408](https://issues.apache.org/jira/browse/NIFI-10408) Improves error handling in `LdapUserGroupProvider` when custom identity mapping properties result in an empty user identity. The new `buildUser()` methods check the content of the mapped user identity prior to building the `User` object, and throw an `IllegalArgumentException` containing the directory reference details when the identity is blank.
   
   Additional changes include using the simplified Apache Commons `BasicThreadFactory` for naming the background synchronization process, updating usage of deprecated `FormatUtils` methods, and replacing `String.format()` with placeholders in several debug log statements.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [X] JDK 11
     - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog closed pull request #6351: NIFI-10408 Improve error handling in LdapUserGroupProvider

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6351: NIFI-10408 Improve error handling in LdapUserGroupProvider
URL: https://github.com/apache/nifi/pull/6351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6351: NIFI-10408 Improve error handling in LdapUserGroupProvider

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6351:
URL: https://github.com/apache/nifi/pull/6351#issuecomment-1232043867

   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6351: NIFI-10408 Improve error handling in LdapUserGroupProvider

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6351:
URL: https://github.com/apache/nifi/pull/6351#issuecomment-1232130681

   +1 will merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org