Re: cvs commit: apache-1.3/src/modules/standard mod_status.c

[Jim Jagielski <ji...@jaguNET.com>]

jim@hyperreal.org wrote:
> 
>   --- CHANGES	1998/10/27 10:20:00	1.1125
>   +++ CHANGES	1998/10/28 13:02:35	1.1126
>   @@ -1,5 +1,10 @@
>    Changes with Apache 1.3.4
>    
>   +  *) Add the actual server_rec structure of the specific Vhost to the
>   +     scoreboard file and avoid a string copy (as well as allow some
>   +     further future enhancements). [Harrie Hazewinkel
>   +     <ha...@jrc.it>]
>   +
>      *) Add APACI --permute-module=foo:bar option which can be used to
>         on-the-fly/batch permute the order of two modules (mod_foo and mod_bar)
>         in the Configuration[.apaci] file. Two special and important variants are
>   
>   1.42      +1 -1      apache-1.3/src/include/scoreboard.h
>   
>   Index: scoreboard.h
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/include/scoreboard.h,v
>   retrieving revision 1.41
>   retrieving revision 1.42
>   diff -u -r1.41 -r1.42
>   --- scoreboard.h	1998/08/11 00:09:43	1.41
>   +++ scoreboard.h	1998/10/28 13:02:37	1.42
>   @@ -130,7 +130,7 @@
>    #endif
>        char client[32];		/* Keep 'em small... */
>        char request[64];		/* We just want an idea... */
>   -    char vhost[32];		/* What virtual host is being accessed? */
>   +    server_rec *vhostrec;	/* What virtual host is being accessed? */

I was thinking, couldn't we do the same for 'request' as well? Simply point
ss->request to r->the_request? This would get rid of another string copy?
Can't do this with 'client' but request seems right.

Taking this even further, couldn't we simply copy a pointer to the real
request_rec itself?? Thus we could grab the request and the vhost (and
all other request info) directly? So the above would be:

	char client[32];
	request_rec *this_request;

and scoreboard could grab this_request->server->server_hostname and
this_request->the_request. This seems quicker and more elegant to me.

Comments??
-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"