You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2008/02/07 11:41:07 UTC
[jira] Created: (SLING-234) RequestDispatcherOption string parsing
in SlingScriptHelper.include(String, String)
RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
-----------------------------------------------------------------------------------
Key: SLING-234
URL: https://issues.apache.org/jira/browse/SLING-234
Project: Sling
Issue Type: Bug
Components: API, Scripting
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: 2.0.0
Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
* If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
* Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-234) RequestDispatcherOption string
parsing in SlingScriptHelper.include(String, String)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566559#action_12566559 ]
Felix Meschberger commented on SLING-234:
-----------------------------------------
In Rev. 619365: Move request dispatcher option parsing to a RequestDispatcherOptions constructor, add unit tests and provide getters and setters for predefined options.
> RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
> -----------------------------------------------------------------------------------
>
> Key: SLING-234
> URL: https://issues.apache.org/jira/browse/SLING-234
> Project: Sling
> Issue Type: Bug
> Components: API, Scripting
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
> * If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
> * Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
> This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-234) RequestDispatcherOption string
parsing in SlingScriptHelper.include(String, String)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566546#action_12566546 ]
Felix Meschberger commented on SLING-234:
-----------------------------------------
In addition to fixing the parsing (and documenting it), the include(String, RequestDispatcherOptions) method removed in Rev. 618697 should be reintroduced.
> RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
> -----------------------------------------------------------------------------------
>
> Key: SLING-234
> URL: https://issues.apache.org/jira/browse/SLING-234
> Project: Sling
> Issue Type: Bug
> Components: API, Scripting
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
> * If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
> * Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
> This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-234) RequestDispatcherOption string parsing
in SlingScriptHelper.include(String, String)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-234.
-----------------------------------
Resolution: Fixed
Closing this now, everything has been updated and adapted.
> RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
> -----------------------------------------------------------------------------------
>
> Key: SLING-234
> URL: https://issues.apache.org/jira/browse/SLING-234
> Project: Sling
> Issue Type: Bug
> Components: API, Scripting
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
> * If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
> * Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
> This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-234) RequestDispatcherOption string
parsing in SlingScriptHelper.include(String, String)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566547#action_12566547 ]
Felix Meschberger commented on SLING-234:
-----------------------------------------
Reintroduced missing method and enhanced JavaDoc in Rev. 619354
> RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
> -----------------------------------------------------------------------------------
>
> Key: SLING-234
> URL: https://issues.apache.org/jira/browse/SLING-234
> Project: Sling
> Issue Type: Bug
> Components: API, Scripting
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
> * If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
> * Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
> This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-234) RequestDispatcherOption string
parsing in SlingScriptHelper.include(String, String)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566560#action_12566560 ]
Felix Meschberger commented on SLING-234:
-----------------------------------------
In Rev. 619366: Adapt sling/core classes to use new RequestDispatcherOptions getter methods.
In Rev. 619367: Remove request dispatcher options parser and unit tests moved to the RequestDispatcherOptions class
> RequestDispatcherOption string parsing in SlingScriptHelper.include(String, String)
> -----------------------------------------------------------------------------------
>
> Key: SLING-234
> URL: https://issues.apache.org/jira/browse/SLING-234
> Project: Sling
> Issue Type: Bug
> Components: API, Scripting
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the RequestDispatcherOptions given to the SlingScriptHelper.include(String path, String options) method are parsed as follows:
> * If the string neither contains a comma nor a colon, the string is interpreted as a resource type. Hence a RequestDispatcherOption object is created setting the "forceResourceType" option to the given string
> * Otherwise the string is parsed using the comma as a separator for the option list and the colon as a separator between an option name and its value.
> This definition of using the colon as a name/value separator collides with the use of the colon as a namespace separator also used in resource types. We should change this to use the equals sign also used in properties files as the separator between names and values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.