You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2020/07/02 21:30:45 UTC

[GitHub] [incubator-nemo] wonook commented on a change in pull request #292: [NEMO-434] Logical DAG modification for Dynamic sampling of task metrics during the execution of a stage

wonook commented on a change in pull request #292:
URL: https://github.com/apache/incubator-nemo/pull/292#discussion_r449274912



##########
File path: common/src/main/java/org/apache/nemo/common/dag/DAGBuilder.java
##########
@@ -169,6 +176,94 @@ public DAGBuilder(final DAG<V, E> dag) {
     return this;
   }
 
+  /**
+   * Use this method when there are no edges to be replaced.
+   * @param edgeToReference edge to reference.
+   * @param edgeToInsert  edge to insert.
+   * @return  itself.
+   */
+  public DAGBuilder<V, E> connectSplitterVertexWithoutReplacing(final E edgeToReference, final E edgeToInsert) {
+    final V src = edgeToInsert.getSrc();
+    final V dst = edgeToInsert.getDst();
+    LOG.error("edgeToReference: {} {} {}", edgeToReference.getId(), edgeToReference.getSrc().getId(),

Review comment:
       Please use the logs accordingly!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org