You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/14 16:47:27 UTC
[GitHub] [helix] rabashizade opened a new pull request #1270: Demo for Dynamically Loading Tasks in Task Framework
rabashizade opened a new pull request #1270:
URL: https://github.com/apache/helix/pull/1270
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1269
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR adds a sample project that can be built independent of Helix, whose JAR file would be provided to Helix Participant and used to dynamically load task classes at the runtime. A test script is also added to run the demo.
### Tests
- [x] The following tests are written for this issue:
TestDemoDynamicTaskLoading
- [ ] The following is the result of the "mvn test" command on the appropriate module:
No changes were made to the code. The following is the result of the build and TestDemoDynamicTaskLoading.
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 2.260 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 3.243 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 2.500 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 5.725 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 3.735 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 41.030 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 6.509 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 10.795 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 1.644 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 3.321 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.043 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 1.330 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 1.395 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 1.152 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 1.066 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 1.035 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:28 min
[INFO] Finished at: 2020-08-14T09:44:45-07:00
[INFO] ------------------------------------------------------------------------
```
```
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.796 s - in org.apache.helix.task.TestDemoDynamicTaskLoading
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.656 s
[INFO] Finished at: 2020-08-14T09:46:33-07:00
[INFO] ------------------------------------------------------------------------
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rabashizade commented on a change in pull request #1270: Demo for Dynamically Loading Tasks in Task Framework
Posted by GitBox <gi...@apache.org>.
rabashizade commented on a change in pull request #1270:
URL: https://github.com/apache/helix/pull/1270#discussion_r470741163
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java
##########
@@ -283,6 +288,78 @@ public void reset() {
}
}
+ /**
Review comment:
Forgot to rebase to dynamically-loaded-tasks, will do shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rabashizade commented on a change in pull request #1270: Demo for Dynamically Loading Tasks in Task Framework
Posted by GitBox <gi...@apache.org>.
rabashizade commented on a change in pull request #1270:
URL: https://github.com/apache/helix/pull/1270#discussion_r470741163
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java
##########
@@ -283,6 +288,78 @@ public void reset() {
}
}
+ /**
Review comment:
Forgot to rebase to dynamically-loaded-tasks, will do shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1270: Demo for Dynamically Loading Tasks in Task Framework
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1270:
URL: https://github.com/apache/helix/pull/1270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org