[jira] Commented: (STANBOL-22) Code copied from geonames, why?

["Rupert Westenthaler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STANBOL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970770#action_12970770 ] 

Rupert Westenthaler commented on STANBOL-22:
--------------------------------------------

Back than (June 2010) I took everything and hoped that the changes are accepted by the project.

Using it as library is not possible, because the needed changes can not be done by that way.
I could apply the changes to Toponym.java in a sub class however the instantiation of
Toponyms is done within a private method within WebService.java. Also the initialization (setting the properties of toponyms based on the xml response of the web service is  done within a private method)

I think the best option is to create a small JSON based client that only supports the two web services actually used by the Geonames Enhancement Engine and to remove the whole fise/ext/org.geonames bundle.

best
Rupert


> Code copied from geonames, why?
> -------------------------------
>
>                 Key: STANBOL-22
>                 URL: https://issues.apache.org/jira/browse/STANBOL-22
>             Project: Stanbol
>          Issue Type: Bug
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>
> A number of stanbol source files have a Geonames copyright. 
> They're Apache-licensed so using that code is ok, but can't we get it as a library instead of forking it?
> find . -name *.java | xargs grep -i "Copyright.*geonames.org"
> ./fise/ext/org.geonames/src/main/java/org/geonames/Address.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/FeatureClass.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/InsufficientStyleException.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/Intersection.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/InvalidParameterException.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/PostalCode.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/PostalCodeSearchCriteria.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/StreetSegment.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/Style.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/Timezone.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/Toponym.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/ToponymSearchCriteria.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/ToponymSearchResult.java: * Copyright 2008 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/utils/Bearing.java: * Copyright 2006 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/utils/Distance.java: * Copyright 2006 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/WebService.java: * Copyright 2008-2010 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/wikipedia/TextSummaryExtractor.java: * Copyright 2007 Marc Wick, geonames.org
> ./fise/ext/org.geonames/src/main/java/org/geonames/WikipediaArticle.java: * Copyright 2008 Marc Wick, geonames.org

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.