You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2020/11/03 15:40:33 UTC

[GitHub] [ambari] dvitiiuk commented on a change in pull request #3254: AMBARI-25569 Reassess Ambari Metrics data migration - 2nd part

dvitiiuk commented on a change in pull request #3254:
URL: https://github.com/apache/ambari/pull/3254#discussion_r516755731



##########
File path: ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/upgrade/core/MetricsDataMigrationLauncher.java
##########
@@ -28,17 +28,15 @@
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.conf.Configuration;
 
-import java.io.BufferedReader;
-import java.io.FileInputStream;
-import java.io.FileWriter;
-import java.io.IOException;
-import java.io.InputStreamReader;
+import java.io.*;

Review comment:
       We don't use wildcards in imports:
   https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org