You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/31 10:37:36 UTC
[GitHub] [cordova-plugin-media-capture] BardRedStar opened a new pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
BardRedStar opened a new pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185
Fixed UI sizing for audio capture controller according to parent view size
### Platforms affected
iOS
### Motivation and Context
Audio capture controller's view looks different for iPhones and iPads and crops according to the device size.
### Description
I changed the size calculation for the audio capture controller's layout. Now the UI looks good on all devices.
### Testing
I didn’t find any tests for this plugin.
### Checklist
- [X] I've run the tests to see all new and existing tests pass
- [X] I added automated test coverage as appropriate for this change
- [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [X] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] ath0mas commented on pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185#issuecomment-854219327
@sdemir60 Yes, as of today nearly all the fixes I merged in my fork are still open PRs on the main repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] ath0mas commented on pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185#issuecomment-776211766
Fixes #176 and #208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] ath0mas commented on pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185#issuecomment-854219327
@sdemir60 Yes, as of today nearly all the fixes I merged in my fork are still open PRs on the main repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] ath0mas commented on pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185#issuecomment-780132987
@timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the [fork](https://github.com/ns0m/cordova-plugin-ns0m-media-capture/releases) I have been successfully using for months now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] sdemir60 commented on pull request #185: iOS: Fixed UI sizing for audio capture controller according to parent view size
Posted by GitBox <gi...@apache.org>.
sdemir60 commented on pull request #185:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/185#issuecomment-847075001
> @timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the [fork](https://github.com/ns0m/cordova-plugin-ns0m-media-capture/releases) I have been successfully using for months now
Thank you very much for your support.
I installed the plugin from the [fork ](https://github.com/ns0m/cordova-plugin-ns0m-media-capture)you created.
These fixes are not available in the main repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org