You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2023/04/22 07:20:12 UTC

[GitHub] [incubator-pekko-connectors-kafka] raboof commented on a diff in pull request #58: scala3 baby step: upgrade scalatest

raboof commented on code in PR #58:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/58#discussion_r1174320018


##########
.github/workflows/check-build-test.yml:
##########
@@ -72,9 +72,13 @@ jobs:
       - name: Cache Coursier cache
         uses: coursier/cache-action@v6
 
-      - name: Compile all code with fatal warnings for Java 11 and Scala 2.12/2.13
+      - name: Compile all code with fatal warnings for Java 11 and Scala 2.12
         # Run locally with: env CI=true sbt 'clean ; Test/compile ; It/compile'
-        run: sbt "; +Test/compile; +It/compile"
+        run: sbt ++2.12.17 " ; Test/compile; It/compile"

Review Comment:
   You can use just `++2.12` so you don't need to keep the minor version in sync manually:
   
   ```suggestion
           run: sbt ++2.12 " ; Test/compile; It/compile"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org