You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/07/12 01:13:38 UTC
Review Request 23426: [HELIX-471] Unregister ResourceMonitor on drop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23426/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-471
Repository: helix-git
Description
-------
commit 521893217ba149f9fb659e9448836cf83e154e86
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Fri Jul 11 16:12:34 2014 -0700
[HELIX-471] Unregister ResourceMonitor on drop
:100644 100644 f427f3d... 008b116... M helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
:100644 100644 5389e76... 4270fe7... M helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
:000000 100644 0000000... 850294d... A helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java f427f3d
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java 5389e76
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java PRE-CREATION
Diff: https://reviews.apache.org/r/23426/diff/
Testing
-------
Added a new integration test that verifies the bean is gone after dropping the resource.
Thanks,
Kanak Biscuitwala
Re: Review Request 23426: [HELIX-471] Unregister ResourceMonitor on drop
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23426/#review47789
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On July 11, 2014, 11:13 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23426/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 11:13 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-471
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 521893217ba149f9fb659e9448836cf83e154e86
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Jul 11 16:12:34 2014 -0700
>
> [HELIX-471] Unregister ResourceMonitor on drop
>
> :100644 100644 f427f3d... 008b116... M helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
> :100644 100644 5389e76... 4270fe7... M helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
> :000000 100644 0000000... 850294d... A helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java f427f3d
> helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java 5389e76
> helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23426/diff/
>
>
> Testing
> -------
>
> Added a new integration test that verifies the bean is gone after dropping the resource.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>