You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/14 13:50:46 UTC

[GitHub] [pulsar-client-go] cornelk opened a new pull request #222: WIP: [Issue 218] Add Seek functions to Reader

cornelk opened a new pull request #222: WIP: [Issue 218] Add Seek functions to Reader
URL: https://github.com/apache/pulsar-client-go/pull/222
 
 
   Fixes #218 
   
   WIP due to `TestReaderSeek` hanging when executing `reader.Next()` after `reader.Seek()` - not sure why this happens and how to continue here, any help or hint is welcome.
   
   ### Motivation
   
   `Seek()` was missing in `Reader` interface but is available in the C++ client lib.
   
   ### Modifications
   
   * implemented Seek in the similar way as `Consumer` does
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - `TestReaderSeek*`
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API: (**yes**)
     - The schema: (don't know)
     - The default values of configurations: (no)
     - The wire protocol: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (GoDocs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services