[GitHub] [solr] dsmiley commented on a diff in pull request #1297: SOLR-14336 Warn users running old version of Solr

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1297:
URL: https://github.com/apache/solr/pull/1297#discussion_r1081711396


##########
solr/webapp/web/js/angular/controllers/index.js:
##########
@@ -20,6 +20,8 @@ solrAdminApp.controller('IndexController', function($scope, System, Cores, Const
   $scope.reload = function() {
     System.get(function(data) {
       $scope.system = data;
+      const releaseDate = parse_release_date($scope.system.lucene['solr-impl-version'])
+      $scope.releaseDaysOld = (new Date() - releaseDate)/60/60/1000/24;

Review Comment:
   the ordering is nonintuitive should be /1000/60/60/24



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org