You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/29 04:02:07 UTC
[GitHub] [tvm] hogepodge opened a new pull request #9394: [docs][bug] Add redirects for moved pages
hogepodge opened a new pull request #9394:
URL: https://github.com/apache/tvm/pull/9394
The documentation refactor moved many pages that have outstanding
links from search engines and other sources. Because we don't
have direct access to the .htaccess file for the TVM docs webserver,
this patch automatically creates manual http redirects from
a list of tuples that provide the old page with the relative
link to the new page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9394: [docs][bug] Add redirects for moved pages
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9394:
URL: https://github.com/apache/tvm/pull/9394#issuecomment-954412052
I’m not attached to how this code is written, and if anyone has suggestions or a better method I’m all ears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #9394: [docs][bug] Add redirects for moved pages
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #9394:
URL: https://github.com/apache/tvm/pull/9394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #9394: [docs][bug] Add redirects for moved pages
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #9394:
URL: https://github.com/apache/tvm/pull/9394#discussion_r739311950
##########
File path: docs/conf.py
##########
@@ -467,5 +467,26 @@ def process_docstring(app, what, name, obj, options, lines):
update_alias_docstring(name, obj, lines)
+from string import Template
+import json
+
+
+def build_redirects(app, docname): # Sphinx expects two arguments
Review comment:
build_legacy_redirect
##########
File path: docs/redirects.data
##########
@@ -0,0 +1,272 @@
+[
Review comment:
how about we leave it as part of pyfile(both to keep things simpler and get around the filetype check, alternatively, rename to .json), the type check do not like json, we can simply embed into the conf.py or legacy_redirect.py.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on a change in pull request #9394: [docs][bug] Add redirects for moved pages
Posted by GitBox <gi...@apache.org>.
hogepodge commented on a change in pull request #9394:
URL: https://github.com/apache/tvm/pull/9394#discussion_r739451842
##########
File path: docs/redirects.data
##########
@@ -0,0 +1,272 @@
+[
Review comment:
I put all of the redirects into one file to keep it localized. I resorted to some anonymous function trickery because I was depending on some paths defined in conf, and had to add the docs directory to the pythonpath since a relative import wouldn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org