You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "krishna-birla (via GitHub)" <gi...@apache.org> on 2023/02/19 13:49:45 UTC
[GitHub] [yunikorn-site] krishna-birla opened a new pull request, #268: [YUNIKORN-1593] Fix typo
krishna-birla opened a new pull request, #268:
URL: https://github.com/apache/yunikorn-site/pull/268
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] krishna-birla commented on pull request #268: [YUNIKORN-1593] Fix typo
Posted by "krishna-birla (via GitHub)" <gi...@apache.org>.
krishna-birla commented on PR #268:
URL: https://github.com/apache/yunikorn-site/pull/268#issuecomment-1436751891
> [YUNIKORN-1589](https://github.com/apache/yunikorn-release/pull/130) is only going into the master at the moment. That change is needed for this doc change correct? If so we should only fix master and not 1.2.0
No, this is completely independent from the helm-chart inline comments.
Yes, it is true that we cannot fix the typos in yunikorn-release/branch-1.2 helm-chart now, but we can fix the website content so that people who refer the website to deploy chart-1.2.0 use the correct values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s closed pull request #268: [YUNIKORN-1593] Fix typo
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #268: [YUNIKORN-1593] Fix typo
URL: https://github.com/apache/yunikorn-site/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #268: [YUNIKORN-1593] Fix typo
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #268:
URL: https://github.com/apache/yunikorn-site/pull/268#issuecomment-1436148118
[YUNIKORN-1589](https://github.com/apache/yunikorn-release/pull/130) is only going into the master at the moment. That change is needed for this doc change correct?
If so we should only fix master and not 1.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org