You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "mlycore (via GitHub)" <gi...@apache.org> on 2023/03/10 06:29:58 UTC
[GitHub] [shardingsphere-on-cloud] mlycore opened a new issue, #258: Refactor: Agent tracing was wrapped twice
mlycore opened a new issue, #258:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/258
Refers to https://github.com/apache/shardingsphere-on-cloud/blob/4ae5381ceff9a1da1df5232bdfb063f62462e1cd/shardingsphere-operator/api/v1alpha1/compute_node_types.go#L166-L180
There is no need to wrap PluginTracing and Tracing for twice. The two struct should be merged into one like below:
```go
// PluginTracing defines the plugin for tracing
type PluginTracing struct {
// +optional
Jaeger JaegerTracing `json:"jaeger,omitempty" yaml:"Jaeger"`
// +optional
Zipkin ZipkinTracing `json:"zipkin,omitempty" yaml:"Zipkin"`
// +optional
SkyWalking SkyWalkingTracing `json:"skyWalking,omitempty" yaml:"SkyWalking"`
// +optional
OpenTelemetry OpenTelemetryTracing `json:"openTelemetry,omitempty" yaml:"OpenTelemetry"`
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on issue #258: Refactor: Agent tracing was wrapped twice
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on issue #258:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/258#issuecomment-1463539868
PR https://github.com/apache/shardingsphere-on-cloud/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore closed issue #258: Refactor: Agent tracing was wrapped twice
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore closed issue #258: Refactor: Agent tracing was wrapped twice
URL: https://github.com/apache/shardingsphere-on-cloud/issues/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #258: Refactor: Agent tracing was wrapped twice
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore commented on issue #258:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/258#issuecomment-1463339160
https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-proxy/observability/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org