[GitHub] garrensmith commented on a change in pull request #1766: Add Global timeout for map/reduce queries

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #1766: Add Global timeout for map/reduce queries
URL: https://github.com/apache/couchdb/pull/1766#discussion_r237370718
 
 

 ##########
 File path: src/fabric/src/fabric_util.erl
 ##########
 @@ -152,6 +152,13 @@ all_docs_timeout() ->
 attachments_timeout() ->
     timeout("attachments", "600000").
 
+global_view_timeout(Args) ->
+    PartitionQuery = couch_mrview_util:get_extra(Args, partition, false),
+    case PartitionQuery of
+        false -> timeout("global_view_timeout", "infinity");
 
 Review comment:
   I've removed the `global_` part for the names. The reason I added that is that rexi has two timeouts. A timeout for how long to wait for each response from a node and then an overall global timeout for the node to send all responses. The view and partition_view are for the second situation where as the `all_docs` and `request` timeouts are fo the individual requests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services