You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/17 20:14:21 UTC
Review Request 72784: Added protobuf messages for regex-based offer
constraints.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.
Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.
Diffs
-----
include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc
include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3
Diff: https://reviews.apache.org/r/72784/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/#review221696
-----------------------------------------------------------
Ship it!
include/mesos/scheduler/scheduler.proto
Lines 335 (patched)
<https://reviews.apache.org/r/72784/#comment310747>
s/ / /
include/mesos/scheduler/scheduler.proto
Lines 337-338 (patched)
<https://reviews.apache.org/r/72784/#comment310748>
Probably we should explain the memory footprint part a bit (i.e. max_mem) and a pointer to our default values? Also we would want to mention that this is tunable via master flags?
Maybe we should advise some values for frameworks, e.g. we recommend rejecting programsize >= X and setting max_mem to Y?
- Benjamin Mahler
On Aug. 24, 2020, 7:37 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72784/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2020, 7:37 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds protobuf messages for setting offer constraints
> that check if agent's (pseudo)attribute matches a specified RE2 regular
> expression.
>
> Both added contsraint predicates will evaluate to `true` when the
> attribute is not TEXT. This way, schedulers will have to apply on their
> own whatever filtration they do for non-TEXT attributes which happen
> to be selected by the constraint's `Selector`.
>
> Given that in the real world schedulers seem to rarely put constraints
> on attributes that are normally Scalar/Ranges, this should not prevent
> them from obtaining performance benefits by setting offer constraints.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 9e89c82a7410a6f1d8f62ffff5366673c0fba541
> include/mesos/v1/scheduler/scheduler.proto cd5a980aff7eb820a11c7887e605e50b73425239
>
>
> Diff: https://reviews.apache.org/r/72784/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 6:38 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Extended the comment on RE2 limits
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.
Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 06d62f5f4ed9286a6ad50f80d1261e4e732d1bc7
include/mesos/v1/scheduler/scheduler.proto 08fb10a146e0b57896a0cb098178a40e618df392
Diff: https://reviews.apache.org/r/72784/diff/4/
Changes: https://reviews.apache.org/r/72784/diff/3-4/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------
(Updated Aug. 24, 2020, 7:37 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Renamed predicates and extended the comment.
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.
Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 9e89c82a7410a6f1d8f62ffff5366673c0fba541
include/mesos/v1/scheduler/scheduler.proto cd5a980aff7eb820a11c7887e605e50b73425239
Diff: https://reviews.apache.org/r/72784/diff/3/
Changes: https://reviews.apache.org/r/72784/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On Aug. 20, 2020, 7:32 p.m., Benjamin Mahler wrote:
> > include/mesos/scheduler/scheduler.proto
> > Lines 292-293 (original), 292-318 (patched)
> > <https://reviews.apache.org/r/72784/diff/1/?file=2238317#file2238317line292>
> >
> > Ditto the comment on the string equality, where I think we can simplify the naming to:
> >
> > RegexMatch
> > RegexNotMatch
> >
> > and explain that we only support TEXT attributes, with non-TEXT getting always passed through to schedulers to do their own filtering
Renamed into `TextMatches` and `TextNotMatches`, which sounds slightly more consistent with `TextEquals`/`TextNotEquals`.
I'm not exactly sure if a more verbose name like `TextMatchesRegex`/`TextNotMatchesRegex` would be better or worse: after all, the first (and the only) field in the message is called `regex`.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/#review221664
-----------------------------------------------------------
On Aug. 24, 2020, 7:37 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72784/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2020, 7:37 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds protobuf messages for setting offer constraints
> that check if agent's (pseudo)attribute matches a specified RE2 regular
> expression.
>
> Both added contsraint predicates will evaluate to `true` when the
> attribute is not TEXT. This way, schedulers will have to apply on their
> own whatever filtration they do for non-TEXT attributes which happen
> to be selected by the constraint's `Selector`.
>
> Given that in the real world schedulers seem to rarely put constraints
> on attributes that are normally Scalar/Ranges, this should not prevent
> them from obtaining performance benefits by setting offer constraints.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 9e89c82a7410a6f1d8f62ffff5366673c0fba541
> include/mesos/v1/scheduler/scheduler.proto cd5a980aff7eb820a11c7887e605e50b73425239
>
>
> Diff: https://reviews.apache.org/r/72784/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/#review221664
-----------------------------------------------------------
include/mesos/scheduler/scheduler.proto
Lines 292-293 (original), 292-318 (patched)
<https://reviews.apache.org/r/72784/#comment310730>
Ditto the comment on the string equality, where I think we can simplify the naming to:
RegexMatch
RegexNotMatch
and explain that we only support TEXT attributes, with non-TEXT getting always passed through to schedulers to do their own filtering
- Benjamin Mahler
On Aug. 20, 2020, 3:16 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72784/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2020, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds protobuf messages for setting offer constraints
> that check if agent's (pseudo)attribute matches a specified RE2 regular
> expression.
>
> Both added contsraint predicates will evaluate to `true` when the
> attribute is not TEXT. This way, schedulers will have to apply on their
> own whatever filtration they do for non-TEXT attributes which happen
> to be selected by the constraint's `Selector`.
>
> Given that in the real world schedulers seem to rarely put constraints
> on attributes that are normally Scalar/Ranges, this should not prevent
> them from obtaining performance benefits by setting offer constraints.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc
> include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3
>
>
> Diff: https://reviews.apache.org/r/72784/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72784: Added protobuf messages for regex-based
offer constraints.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------
(Updated Aug. 20, 2020, 3:16 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Extended the comment to explain the purpose of non-TEXT pass-through.
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.
Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc
include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3
Diff: https://reviews.apache.org/r/72784/diff/2/
Changes: https://reviews.apache.org/r/72784/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko