You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2013/07/24 15:17:57 UTC

[jira] [Commented] (OAK-672) Avoid JCR APIs calling other JCR APIs

    [ https://issues.apache.org/jira/browse/OAK-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718349#comment-13718349 ] 

Jukka Zitting commented on OAK-672:
-----------------------------------

I moved the protection check to delegates in revision 1506517.
                
> Avoid JCR APIs calling other JCR APIs
> -------------------------------------
>
>                 Key: OAK-672
>                 URL: https://issues.apache.org/jira/browse/OAK-672
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Michael Dürig
>
> As discussed [on the list | http://markmail.org/message/avqtnfamdp56jsqy] we should avoid implementing JCR methods in terms of other JCR methods but rather factor the commonalities out into a common method of the respective delegate. 
> JCR methods calling each other is problematic since it duplicates pre condition checks and makes it considerable more difficult to guarantee certain invariants during the course of the method call (see the discussion wrt. refresh earlier in above thread). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira