You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2025/03/01 16:10:40 UTC
[PR] fix(plugin-chart-echarts): remove erroneous upper bound value [superset]
villebro opened a new pull request, #32473:
URL: https://github.com/apache/superset/pull/32473
### SUMMARY
Currently when selecting "show value" on the chart, the upper bound shows the confidence bound width (400), not the actual value (which is 1.76k). In the tooltip this is fixed by adding the lower bound to the upper bound. However, this is more difficult to implement in the label formatter, as it only receives the single value of the series, while the tooltip formatter receives all series, making it easier to do the addition.
### BEFORE
Notice the incorrect upper bound label (400), as opposed to the actual value seen on the tooltip (1.76k):
<img width="1012" alt="image" src="https://github.com/user-attachments/assets/11391d6e-b79b-4fad-acf1-bebcd7060e68" />
### AFTER
Now the lower and upper bound labels are no longer shown when hovering:
<img width="1017" alt="image" src="https://github.com/user-attachments/assets/77b4e1e7-a683-4811-b378-456f8440572c" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-echarts): remove erroneous upper bound value [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #32473:
URL: https://github.com/apache/superset/pull/32473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-echarts): remove erroneous upper bound value [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #32473:
URL: https://github.com/apache/superset/pull/32473#issuecomment-2692577318
> LGTM. I haven't checked if the feature is covered by RTL, but maybe there's an enhancement if so. If it's enzyme, then I wouldn't bother at this time.
I don't think this is testable with RTL, as we're just wrapping ECharts in a thin React component (ECharts implements all the drawing stuff at a very low level with ZRender). But working on this gave me a good proper headache, so this plugin is definitely in need of some cleanup at some point. Once we have the new extensions architecture in place, I'd love for us to give this plugin some TLC and rethink how we can do some real RTL-style testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org