You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Daniel Ruggeri <dr...@primary.net> on 2018/09/18 00:56:52 UTC

[VOTE] Release httpd-2.4.35

Hi, all;
   Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this
candidate tarball as 2.4.35:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
*httpd-2.4.35.tar.gz

-- 
Daniel Ruggeri


Re: [VOTE] Release httpd-2.4.35

Posted by Noel Butler <no...@ausics.net>.
On 18/09/2018 10:56, Daniel Ruggeri wrote:

> Hi, all;
> Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/

all good on slackware 13.0+ with apr 1.6.5 and apr-util 1.6.1

-- 
Kind Regards, 

Noel Butler 

 		This Email, including any attachments, may contain legally privileged
information, therefore remains confidential and subject to copyright
protected under international law. You may not disseminate, discuss, or
reveal, any part, to anyone, without the authors express written
authority to do so. If you are not the intended recipient, please notify
the sender then delete all copies of this message including attachments,
immediately. Confidentiality, copyright, and legal privilege are not
waived or lost by reason of the mistaken delivery of this message. Only
PDF [1] and ODF [2] documents accepted, please do not send proprietary
formatted documents 

 

Links:
------
[1] http://www.adobe.com/
[2] http://en.wikipedia.org/wiki/OpenDocument

Re: [VOTE] Release httpd-2.4.35

Posted by Stefan Eissing <st...@greenbytes.de>.
+1

h2 testsuite:
-  MacOS 10.13
- Ubuntu 16.04.5 LTS (i386)
- Ubuntu 16.04.5 LTS (x86_64)

md testsuite
-  MacOS 10.13

Looks good, thanks for RMing!

-Stefan

> Am 18.09.2018 um 02:56 schrieb Daniel Ruggeri <dr...@primary.net>:
> 
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
> 
> -- 
> Daniel Ruggeri
> 


Re: RESULT: Passed - [VOTE] Release httpd-2.4.35

Posted by Marion & Christophe JAILLET <ch...@wanadoo.fr>.
FYI, 2.4.35 version has been added to bz.

CJ


Le 21/09/2018 à 14:31, Daniel Ruggeri a écrit :
> Hi, all;
>
>     I am delighted to share that the vote to release Apache httpd-2.4.35
> has PASSED. The following votes were recorded:
>
> Binding +1:
> minfrin, icing, jorton, gsmith, steffenal, covener, jailletc36, ylavic,
> rjung, druggeri, wroewe
>
> Community +1:
> Noel Butler
>
>
> I'd like to add that, as an RM, I am VERY pleased that we received 12
> votes in only 3.5 days. I thank you for all the time you've put into
> this project and into testing this release.
>
> ANNOUNCE text will be updated a bit later today (with a note about
> OpenSSL and upcoming TLS 1.3) and I've kicked off the dist sync process.
>
> I will also plan to RM a followup release as promised now that the TLS
> 1.3 change has been merged... but let's give that a few weeks for other
> features to make it into 2.4.x :-)
>


RESULT: Passed - [VOTE] Release httpd-2.4.35

Posted by Daniel Ruggeri <dr...@primary.net>.
Hi, all;

   I am delighted to share that the vote to release Apache httpd-2.4.35
has PASSED. The following votes were recorded:

Binding +1:
minfrin, icing, jorton, gsmith, steffenal, covener, jailletc36, ylavic,
rjung, druggeri, wroewe

Community +1:
Noel Butler


I'd like to add that, as an RM, I am VERY pleased that we received 12
votes in only 3.5 days. I thank you for all the time you've put into
this project and into testing this release.

ANNOUNCE text will be updated a bit later today (with a note about
OpenSSL and upcoming TLS 1.3) and I've kicked off the dist sync process.

I will also plan to RM a followup release as promised now that the TLS
1.3 change has been merged... but let's give that a few weeks for other
features to make it into 2.4.x :-)

-- 
Daniel Ruggeri

On 9/17/2018 7:56 PM, Daniel Ruggeri wrote:
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
>


Re: [VOTE] Release httpd-2.4.35

Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Mon, Sep 17, 2018 at 7:57 PM Daniel Ruggeri <dr...@primary.net> wrote:

> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>

+1, liking what I've observed on Win32/CMake, Ubuntu-on-windows, and Fedora.
Have not had a chance to complete all of my review owing to some really
wonky
new Windows strict case path behavior, but the vote time ends, is good
enough!

Re: [VOTE] Release httpd-2.4.35

Posted by Steffen <in...@apachelounge.com>.
All fine here on Windows. 

> Op 18 sep. 2018 om 02:56 heeft Daniel Ruggeri <dr...@primary.net> het volgende geschreven:
> 
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
> 
> -- 
> Daniel Ruggeri
> 


Re: [VOTE] Release httpd-2.4.35

Posted by Dennis Clarke <dc...@blastwave.org>.
On 09/19/2018 01:18 PM, Gregg Smith wrote:
> On 9/17/2018 5:56 PM, Daniel Ruggeri wrote:
>> Hi, all;
>>     Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release ...


Nothing seen working on Solaris x86 or SPARC yet and I have yet to
really throw myself at it.  Don't let it hold anything back. I hardly
see it as a large percentage of the user space anyways.

I'll look at it starting later today.

Dennis Clarke

Re: [VOTE] Release httpd-2.4.35

Posted by Gregg Smith <gl...@gknw.net>.
On 9/17/2018 5:56 PM, Daniel Ruggeri wrote:
> Hi, all;
>     Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 

+1 on Windows w/ apr/1.6.5, apu/1.6.1

vc11 32 & 64 bit w/ OpenSSL 1.0.2p
vc14 32 & 64 bit w/ OpenSSL 1.0.2p & 1.1.0i

Thanks for RMing Daniel

Re: [VOTE] Release httpd-2.4.35

Posted by Eric Covener <co...@gmail.com>.
On Mon, Sep 17, 2018 at 8:57 PM Daniel Ruggeri <dr...@primary.net> wrote:
>
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.

+1, AIX/xlc/ppc64 w/ openssl 1.1.1 (1.1.0 has issues on AIX)

Not 100% but as good as can be expected on my aging perl+prereqs

For posterity:

Test Summary Report
-------------------
t/ab/base.t                       (Wstat: 0 Tests: 5 Failed: 4)
  Failed tests:  1-4
t/modules/http2.t                 (Wstat: 0 Tests: 24 Failed: 0)
  Parse errors: Bad plan.  You planned 52 tests but ran 24.
t/ssl/proxy.t                     (Wstat: 0 Tests: 172 Failed: 118)
  Failed tests:  1-59, 114-172
t/ssl/varlookup.t                 (Wstat: 9 Tests: 74 Failed: 0)
  Non-zero exit status: -1
  Parse errors: Bad plan.  You planned 83 tests but ran 74.
Files=123, Tests=8537, 3811 wallclock secs ( 2.60 usr  0.36 sys +
49.25 cusr 22.23 csys = 74.44 CPU)
Result: FAIL
Failed 4/123 test programs. 122/8537 subtests failed.
[warning] server localhost:8529 shutdown

Re: [VOTE] Release httpd-2.4.35

Posted by Joe Orton <jo...@redhat.com>.
On Mon, Sep 17, 2018 at 07:56:52PM -0500, Daniel Ruggeri wrote:
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.

+1 for release, passes tests on Fedora 28 (OpenSSL 1.1.0h), CHANGES 
looks good.

Thanks for RMing, Daniel!

Regards, Joe

Re: [VOTE] Release httpd-2.4.35

Posted by Daniel Ruggeri <dr...@primary.net>.
+1 with the following test suite:
system:
   kernel:
     name: Linux
     release: 3.16.0-4-amd64
     version: #1 SMP Debian 3.16.51-3 (2017-12-13)
     machine: x86_64

   libraries:
     openssl: "1.1.0i"
     openldap: "2.4.46"
     apr: "1.6.5"
     apr-util: "1.6.1"
     iconv: "1.2.2"
     brotli: "1.0.6"
     nghttp2: "1.33.0"
     zlib: "1.2.11"
     pcre: "8.42"
     libxml2: "2.9.8"
     php: "5.6.38"
     lua: "5.3.5"
     curl: "7.61.1"

On 2018-09-17 19:56, Daniel Ruggeri wrote:
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 
> 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz

-- 
Daniel Ruggeri

Re: [VOTE] Release httpd-2.4.35

Posted by Graham Leggett <mi...@sharp.fm>.
On 18 Sep 2018, at 02:56, Daniel Ruggeri <dr...@primary.net> wrote:

>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.

+1 on MacOS High Sierra, FC23.

Regards,
Graham
—


Re: [VOTE] Release httpd-2.4.35

Posted by Daniel Ruggeri <dr...@primary.net>.
Hi, Steffen;

   Good catch. That particular change didn't have a CHANGES entry, so it
explains why it's missing. Luckily, there are no user-visible changes
(other than the error message being correct), so I think we're good to
move forward. Would love to see a test case added around this if you're
so inclined :-)


Thanks!

-- 
Daniel Ruggeri

On 9/21/2018 5:59 AM, Steffen wrote:
> Maybe I overlook it:
>
> I miss in the change log:
>
> http://svn.apache.org/viewvc?view=revision&sortby=date&revision=1840546
>
> Looks it needs special windows test attention.
>
> Description:
>
> Merge r1801144, r1801148, r1801456 from trunk:
>
> mpm_winnt: Factor out a helper function to parse the type of an accept
> filter and use an appropriate enum for it.
>
> This makes the code in winnt_accept() a bit easier to follow.  As a minor
> side effect, it also fixes a small bug where the "unrecognized
> AcceptFilter
> '%s'" log entry would always contain "none" instead of the actually
> unrecognized kind of the accept filter.
>
> mpm_winnt: Fix typo in the logged message in winnt_get_connection().
>
> mpm_winnt: Following up on r1801144, use the new accept_filter_e enum
> values in a couple of missed places in winnt_accept().
>
> Submitted by: kotkov
> Reviewed by: jailletc36, jim (via inspection), wrowe
>
>
>
> On 18-09-18 02:56, Daniel Ruggeri wrote:
>> Hi, all;
>>     Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release this
>> candidate tarball as 2.4.35:
>> [ ] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>
>> The computed digests of the tarball up for vote are:
>> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
>> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
>> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
>> *httpd-2.4.35.tar.gz
>>
>


Re: [VOTE] Release httpd-2.4.35

Posted by Steffen <in...@apachelounge.com>.
Maybe I overlook it:

I miss in the change log:

http://svn.apache.org/viewvc?view=revision&sortby=date&revision=1840546

Looks it needs special windows test attention.

Description:

Merge r1801144, r1801148, r1801456 from trunk:

mpm_winnt: Factor out a helper function to parse the type of an accept
filter and use an appropriate enum for it.

This makes the code in winnt_accept() a bit easier to follow.  As a minor
side effect, it also fixes a small bug where the "unrecognized AcceptFilter
'%s'" log entry would always contain "none" instead of the actually
unrecognized kind of the accept filter.

mpm_winnt: Fix typo in the logged message in winnt_get_connection().

mpm_winnt: Following up on r1801144, use the new accept_filter_e enum
values in a couple of missed places in winnt_accept().

Submitted by: kotkov
Reviewed by: jailletc36, jim (via inspection), wrowe



On 18-09-18 02:56, Daniel Ruggeri wrote:
> Hi, all;
>     Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
>


Re: [VOTE] Release httpd-2.4.35

Posted by Rainer Jung <ra...@kippdata.de>.
Am 21.09.2018 um 04:18 schrieb Dennis Clarke:
> 
>> +1 for release and thanks for RM.
>>
>> Not enough time right now for the usual detailed report, but so far 
>> looks good on Solaris 10 Sparc, SLES 11+12, RHEL 6+7.
>>
> 
> 
> Thank you for getting to it before I did. I can ignore it now ;-)

Not necessarily, your input typically is very valuable. There's so much 
possible variation in compilers, library versions, linking type, OS 
patches etc. etc.

But if you are short on time: merging support for TLS 1.3 will likely be 
the next step for httpd 2.4 and intensive testing then will be much 
appreciated.

Thanks and regards,

Rainer


Re: [VOTE] Release httpd-2.4.35

Posted by Dennis Clarke <dc...@blastwave.org>.
> +1 for release and thanks for RM.
> 
> Not enough time right now for the usual detailed report, but so far 
> looks good on Solaris 10 Sparc, SLES 11+12, RHEL 6+7.
> 


Thank you for getting to it before I did. I can ignore it now ;-)

Dennis



Re: [VOTE] Release httpd-2.4.35

Posted by Rainer Jung <ra...@kippdata.de>.
Am 18.09.2018 um 02:56 schrieb Daniel Ruggeri:
> Hi, all;
>     Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [X] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz

+1 for release and thanks for RM.

Not enough time right now for the usual detailed report, but so far 
looks good on Solaris 10 Sparc, SLES 11+12, RHEL 6+7.

Regards,

Rainer


Re: [VOTE] Release httpd-2.4.35

Posted by Daniel Ruggeri <dr...@primary.net>.
Wow - that's actually really cool! Thanks for sharing - would love to 
see a HOWTO.

-- 
Daniel Ruggeri

On 2018-09-19 14:59, Christophe JAILLET wrote:
> Le 18/09/2018 à 02:56, Daniel Ruggeri a écrit :
>> Hi, all;
>>     Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>> 
>> I would like to call a VOTE over the next few days to release this
>> candidate tarball as 2.4.35:
>> [X] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>> 
>> The computed digests of the tarball up for vote are:
>> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
>> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
>> sha256: 
>> 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
>> *httpd-2.4.35.tar.gz
>> 
> +1
> 
> Ubuntu 18.04
> gcc 8.1
> 
> 
> I now build with gcc test-coverage options. Attached, the results on
> my machine after a t/TEST.
> I use a slightly modified version of the script I've updated for APR.
> (don't pay attention to all the APR related text in the attached file
> :))
> 
> This gives the picture of what need more love in the test-framework. I
> can share the corresponding .gcov files to see which lines are never
> executed while running the tests.
> This still need to be improved and I will post one day a How-To about 
> it.
> 
> Based on it, I'll try to add some new test-cases to improve the test
> coverage of the test-framework. (i.e. see my latest additions for
> modules that were completely untested (reflector.t; allowmethods.t) or
> some paths not tested (setenvif.t))
> We'll never be able to test all possible combination, but the more
> lines are executed at least one, the better it is.
> 
> Thx for RM
> 
> CJ


Re: [VOTE] Release httpd-2.4.35

Posted by Christophe JAILLET <ch...@wanadoo.fr>.
Le 18/09/2018 à 02:56, Daniel Ruggeri a écrit :
> Hi, all;
>     Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [X] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
>
+1

Ubuntu 18.04
gcc 8.1


I now build with gcc test-coverage options. Attached, the results on my 
machine after a t/TEST.
I use a slightly modified version of the script I've updated for APR. 
(don't pay attention to all the APR related text in the attached file :))

This gives the picture of what need more love in the test-framework. I 
can share the corresponding .gcov files to see which lines are never 
executed while running the tests.
This still need to be improved and I will post one day a How-To about it.

Based on it, I'll try to add some new test-cases to improve the test 
coverage of the test-framework. (i.e. see my latest additions for 
modules that were completely untested (reflector.t; allowmethods.t) or 
some paths not tested (setenvif.t))
We'll never be able to test all possible combination, but the more lines 
are executed at least one, the better it is.

Thx for RM

CJ

Re: [VOTE] Release httpd-2.4.35

Posted by Stefan Eissing <st...@greenbytes.de>.
Apologies, my mistake. Was going down the wrong rabbit hole and ended in a version 0.0.01 off.

:-S Stefan

> Am 19.09.2018 um 11:05 schrieb Daniel Gruno <hu...@apache.org>:
> 
> On 09/19/2018 10:56 AM, Stefan Eissing wrote:
>> -1, the tag is not from HEAD of 2.4.x.
>> Specifically it seems to me it is missing:
>> r1840757 | jim | 2018-09-12 22:38:02 +0200 (Mi, 12 Sep 2018) | 12 lines
>> Merge r1840010 from trunk:
>> ...
>> Can someone confirm that the tag seems to miss changes at the time it was done?
> 
> Cannot confirm, the merge is present in the 2.4.35 tag.
> Where are you not seeing your changes?
> 
> I checked http://svn.apache.org/viewvc/httpd/httpd/tags/2.4.35/modules/http2/h2_session.c?view=markup and the changes are there..
> 
>> -Stefan
>>> Am 18.09.2018 um 02:56 schrieb Daniel Ruggeri <dr...@primary.net>:
>>> 
>>> Hi, all;
>>>    Please find below the proposed release tarball and signatures:
>>> https://dist.apache.org/repos/dist/dev/httpd/
>>> 
>>> I would like to call a VOTE over the next few days to release this
>>> candidate tarball as 2.4.35:
>>> [ ] +1: It's not just good, it's good enough!
>>> [ ] +0: Let's have a talk.
>>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>> 
>>> The computed digests of the tarball up for vote are:
>>> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
>>> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
>>> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
>>> *httpd-2.4.35.tar.gz
>>> 
>>> -- 
>>> Daniel Ruggeri
>>> 
> 


Re: [VOTE] Release httpd-2.4.35

Posted by Daniel Gruno <hu...@apache.org>.
On 09/19/2018 10:56 AM, Stefan Eissing wrote:
> -1, the tag is not from HEAD of 2.4.x.
> 
> Specifically it seems to me it is missing:
> 
> r1840757 | jim | 2018-09-12 22:38:02 +0200 (Mi, 12 Sep 2018) | 12 lines
> 
> Merge r1840010 from trunk:
> 
> ...
> 
> Can someone confirm that the tag seems to miss changes at the time it was done?

Cannot confirm, the merge is present in the 2.4.35 tag.
Where are you not seeing your changes?

I checked 
http://svn.apache.org/viewvc/httpd/httpd/tags/2.4.35/modules/http2/h2_session.c?view=markup 
and the changes are there..

> 
> -Stefan
> 
>> Am 18.09.2018 um 02:56 schrieb Daniel Ruggeri <dr...@primary.net>:
>>
>> Hi, all;
>>     Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release this
>> candidate tarball as 2.4.35:
>> [ ] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>
>> The computed digests of the tarball up for vote are:
>> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
>> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
>> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
>> *httpd-2.4.35.tar.gz
>>
>> -- 
>> Daniel Ruggeri
>>
> 


Re: [VOTE] Release httpd-2.4.35

Posted by Stefan Eissing <st...@greenbytes.de>.
-1, the tag is not from HEAD of 2.4.x. 

Specifically it seems to me it is missing:

r1840757 | jim | 2018-09-12 22:38:02 +0200 (Mi, 12 Sep 2018) | 12 lines

Merge r1840010 from trunk:

...

Can someone confirm that the tag seems to miss changes at the time it was done?

-Stefan

> Am 18.09.2018 um 02:56 schrieb Daniel Ruggeri <dr...@primary.net>:
> 
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.35:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz
> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz
> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c
> *httpd-2.4.35.tar.gz
> 
> -- 
> Daniel Ruggeri
> 


Re: [VOTE] Release httpd-2.4.35

Posted by Yann Ylavic <yl...@gmail.com>.
+1: It's not just good, it's good enough!

Tested on Debian(s) 7/8/9/10, MPM event/worker/prefork, APR 1.6.5,
OpenSSL 1.0.1 => 1.1.0.

Thanks Daniel.

Re: [VOTE] Release httpd-2.4.35

Posted by Nick Kew <ni...@apache.org>.
On Mon, 17 Sep 2018 19:56:52 -0500
Daniel Ruggeri <dr...@primary.net> wrote:

> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 

Builds fine (once I'd found a keyserver that would talk to
my gpg today), but the tests bombed on me. Unlikely to have
time to dig into that before at least Friday, so no vote
likely unless you leave it open all week or thereabouts.

-- 
Nick Kew