You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by dk...@apache.org on 2020/05/21 14:39:41 UTC

[avro] 02/02: AVRO-2569:Merge use cases reduce CI consumption

This is an automated email from the ASF dual-hosted git repository.

dkulp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git

commit 641193688c0ec49a46af041d2d7b7fe1e8f108ec
Author: zeshuai007 <51...@qq.com>
AuthorDate: Wed Oct 30 15:47:16 2019 +0800

    AVRO-2569:Merge use cases reduce CI consumption
---
 .../apache/avro/compiler/specific/TestSpecificCompiler.java  | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java b/lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
index b13d7c5..5953f21 100644
--- a/lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
+++ b/lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
@@ -424,6 +424,10 @@ public class TestSpecificCompiler {
     Assert.assertEquals("Should use double for Type.DOUBLE", "double", compiler.javaUnbox(doubleSchema, false));
     Assert.assertEquals("Should use boolean for Type.BOOLEAN", "boolean", compiler.javaUnbox(boolSchema, false));
 
+    // see AVRO-2569
+    Schema nullSchema = Schema.create(Schema.Type.NULL);
+    Assert.assertEquals("Should use void for Type.NULL", "void", compiler.javaUnbox(nullSchema, true));
+
     Schema dateSchema = LogicalTypes.date().addToSchema(Schema.create(Schema.Type.INT));
     Schema timeSchema = LogicalTypes.timeMillis().addToSchema(Schema.create(Schema.Type.INT));
     Schema timestampSchema = LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
@@ -438,14 +442,6 @@ public class TestSpecificCompiler {
   }
 
   @Test
-  public void testJavaUnboxNullToVoid() throws Exception {
-    // see AVRO-2569
-    SpecificCompiler compiler = createCompiler();
-    Schema nullSchema = Schema.create(Schema.Type.NULL);
-    Assert.assertEquals("Should use void for Type.NULL", "void", compiler.javaUnbox(nullSchema, true));
-  }
-
-  @Test
   public void testJavaUnboxDateTime() throws Exception {
     SpecificCompiler compiler = createCompiler();