[GitHub] [beam] scwhittle commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix

[GitBox <gi...@apache.org>]

scwhittle commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r720188218



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -556,25 +565,35 @@ public ResourceId apply(ResourceId tempDirectory) {
      */
     @Experimental(Kind.FILESYSTEM)
     public WriteOperation(FileBasedSink<?, DestinationT, OutputT> sink, ResourceId tempDirectory) {
-      this(sink, StaticValueProvider.of(tempDirectory));
+      this(sink, StaticValueProvider.of(tempDirectory), false);

Review comment:
       The failures seem relevant as the test also performs a write before reading.
   
   Trying to reproduce locally so I can debug.  I'm wondering if it is failing since it is trying to write to some protected dir in tests or a directory needs to be created.
   
   I don't think that should be true there because the previous behavior was to not subdirectory, as the staticvalueprovider was used instead of the TemporaryDirectoryBuilder provider that created the subdir used by other constructor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org