You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2019/11/25 02:54:37 UTC
[zeppelin] branch master updated: [HOTFIX] Fix test fails after
ZEPPELIN-4408
This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new 99ebf07 [HOTFIX] Fix test fails after ZEPPELIN-4408
99ebf07 is described below
commit 99ebf07de88588bf87c50fecaf6a7e3505b4c13f
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Mon Nov 25 10:54:18 2019 +0800
[HOTFIX] Fix test fails after ZEPPELIN-4408
---
.../src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java | 1 -
.../java/org/apache/zeppelin/interpreter/BaseZeppelinContext.java | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java b/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java
index 6a03b69..1feb002 100644
--- a/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java
+++ b/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java
@@ -105,7 +105,6 @@ public class SparkInterpreterTest {
// incomplete
result = interpreter.interpret("println(a", getInterpreterContext());
assertEquals(InterpreterResult.Code.INCOMPLETE, result.code());
- assertEquals("Incomplete expression", result.message());
// syntax error
result = interpreter.interpret("println(b)", getInterpreterContext());
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/BaseZeppelinContext.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/BaseZeppelinContext.java
index dbda06e..35de1af 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/BaseZeppelinContext.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/BaseZeppelinContext.java
@@ -276,9 +276,9 @@ public abstract class BaseZeppelinContext {
List<Object> defaultChecked,
boolean noteForm) {
if (defaultChecked == null ) {
- List<Object> defaultValues = new LinkedList<>();
+ defaultChecked = new ArrayList<>();
for (ParamOption option : options) {
- defaultValues.add(option.getValue());
+ defaultChecked.add(option.getValue());
}
}
if (noteForm) {