[GitHub] [superset] vfoucault commented on pull request #12868: feat: helm chart oauth configuration

[GitBox <gi...@apache.org>]

vfoucault commented on pull request #12868:
URL: https://github.com/apache/superset/pull/12868#issuecomment-778610465


   > hi @vfoucault  and thanks for your contribution 
   > IMO we should add configurations in a more generic approach by adding different configs and not hardcoded in the YAML code
   > look in here: https://github.com/apache/superset/pull/13096
   
   Hum, i am quite perplexe about that  because nothing is fixed here as you may specify your own oauth configuration that will be converted to json.
   
   If you prefer to add a complex  string into a yaml code, I wouldn't say that this is an improvement thought I must agree that the idea of a generic configuration overrider is quite good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org