You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/18 11:09:35 UTC

[GitHub] [druid] jp707049 opened a new pull request #11613: Added prometheus-emitter docs which was missing

jp707049 opened a new pull request #11613:
URL: https://github.com/apache/druid/pull/11613


   ### Description
   Currently in the latest druid docs, we cannot find the documentation related to prometheus emitter (https://druid.apache.org/docs/latest/development/extensions.html#community-extensions).
   
   Update the main `extension.md` to add `prometheus-emitter` docs.
   
   This PR has:
   - [ x ] been self-reviewed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] clintropolis commented on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901729722


   >@suneet-s It's now showing spell check error but I looked it up and spelling is correct for prometheus.
   
   The spelling custom words file is pointing to the old path, https://github.com/apache/druid/blob/master/website/.spelling#L611. It either needs fixed to point to the new path, or the entries from this path moved to the top part of the file which is stuff that applies to all files. (Not really sure why we have both global entries and path specific entries...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jp707049 commented on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
jp707049 commented on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901580018


   @suneet-s It's now showing spell check error but I looked it up and spelling is correct for prometheus. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901265788


   @jp707049 The docs failure appears to be legit - it is complaining about a broken link
   
   ```
   [WARN] unresolved links in file 'development/extensions.md' > [ '../development/extensions-contrib/prometheus.md' ]
   sitemap.js triggered...
   Site built successfully. Generated files in 'build' folder.
   Could not find '../development/extensions-contrib/prometheus.md' linked from './build/ApacheDruid/docs/development/extensions.html'
   There are 1 issues
   ```
   
   You can run the tests locally if you want to try it out by reading `.travis.yml` and looking at the `docs` job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jp707049 closed pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
jp707049 closed pull request #11613:
URL: https://github.com/apache/druid/pull/11613


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jp707049 removed a comment on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
jp707049 removed a comment on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901269582


   @suneet-s , 
   I actually fixed that in above commit `Rename prometheus.md to prometheus-emitter.md` 
   I renamed the file from `prometheus.md` to `prometheus-emitter.md`. Here is the link  to the commit 
   https://github.com/jp707049/druid/commit/71990ed47f61506ad91e9faa620a8a97845ab5e4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jp707049 commented on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
jp707049 commented on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901259730






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jp707049 commented on pull request #11613: Added prometheus-emitter docs which was missing

Posted by GitBox <gi...@apache.org>.
jp707049 commented on pull request #11613:
URL: https://github.com/apache/druid/pull/11613#issuecomment-901736122


   I will create a new PR with filename `prometheus.md`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org