You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by maasg <gi...@git.apache.org> on 2017/08/11 15:29:19 UTC

[GitHub] spark pull request #18923: [SPARK-21710][SS] Fix OOM on ConsoleSink with lar...

GitHub user maasg opened a pull request:

    https://github.com/apache/spark/pull/18923

    [SPARK-21710][SS] Fix OOM on ConsoleSink with large inputs

    ## What changes were proposed in this pull request?
    
    Replace a full `collect` with a `take` using the expected number of elements as output, which is readily available at this point.
    
    ## How was this patch tested?
    
    existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maasg/spark-1 SPARK-21710_console_sink_oom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18923.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18923
    
----
commit bd521e0f4b3b583e182b0fd6ab9d284b5c6e7f37
Author: Gerard Maas <ge...@gmail.com>
Date:   2017-08-11T14:46:34Z

    replaces a full `collect` for a `take` with the requested number of elements for the console to show

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by maasg <gi...@git.apache.org>.
Github user maasg commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Outdated by Datasource V2 implementation. Closing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Jenkins, test this please.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by maasg <gi...@git.apache.org>.
Github user maasg commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    @zsxwing sorry, lost track of this. Will do. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18923#discussion_r132792708
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala ---
    @@ -49,7 +49,7 @@ class ConsoleSink(options: Map[String, String]) extends Sink with Logging {
         println("-------------------------------------------")
         // scalastyle:off println
         data.sparkSession.createDataFrame(
    -      data.sparkSession.sparkContext.parallelize(data.collect()), data.schema)
    --- End diff --
    
    This might not be safe unfortunately.  Anything that changes the query plan might cause it to get replanned (and we don't do this correctly).
    
    Can you make sure that there is a test case that uses the console sink and does aggregation across more than one batch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18923#discussion_r133335831
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala ---
    @@ -49,7 +49,7 @@ class ConsoleSink(options: Map[String, String]) extends Sink with Logging {
         println("-------------------------------------------")
         // scalastyle:off println
         data.sparkSession.createDataFrame(
    -      data.sparkSession.sparkContext.parallelize(data.collect()), data.schema)
    --- End diff --
    
    I think we also need to consume all data to change the internal states in stateful operators. How about this:
    ```Scala
        val encoder = data.exprEnc.resolveAndBind(
          data.logicalPlan.output,
          data.sparkSession.sessionState.analyzer)
    
        val numRowsToFetch = numRowsToShow + 1
        val takeResult = data.queryExecution.toRdd.mapPartitions { iter =>
          var numFetched = 0
          val v = ArrayBuffer[Row]()
          while (numFetched < numRowsToFetch && iter.hasNext) {
            v += encoder.fromRow(iter.next())
            numFetched += 1
          }
          // Consume all data to update internal states in stateful operators.
          while (iter.hasNext) {
            iter.next()
          }
          v.iterator
        }.collect().toSeq.take(numRowsToFetch)
    
        data.sparkSession.createDataFrame(
          data.sparkSession.sparkContext.parallelize(takeResult),
          data.schema).show(numRowsToShow, isTruncated)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

Posted by maasg <gi...@git.apache.org>.
Github user maasg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18923#discussion_r132794142
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala ---
    @@ -49,7 +49,7 @@ class ConsoleSink(options: Map[String, String]) extends Sink with Logging {
         println("-------------------------------------------")
         // scalastyle:off println
         data.sparkSession.createDataFrame(
    -      data.sparkSession.sparkContext.parallelize(data.collect()), data.schema)
    --- End diff --
    
    @marmbrus Michael, that's unfortunate. The OOM risk might be common to any source that can deliver a high volume of data at once (file source in my test case, but I would expect that a loaded kafka topic read from `earliest` will behave in the same way).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18923#discussion_r132801760
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala ---
    @@ -49,7 +49,7 @@ class ConsoleSink(options: Map[String, String]) extends Sink with Logging {
         println("-------------------------------------------")
         // scalastyle:off println
         data.sparkSession.createDataFrame(
    -      data.sparkSession.sparkContext.parallelize(data.collect()), data.schema)
    --- End diff --
    
    I don't think this means we can't do anything.  I just think that we need to fix the query plan and call take without changing the plan.  Its kind of a hack but it would work until we make the planner smarter.
    
    I think something like `data.queryExecution.executedPlan.executeTake(...)` would be safe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    **[Test build #3889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3889/testReport)** for PR 18923 at commit [`bd521e0`](https://github.com/apache/spark/commit/bd521e0f4b3b583e182b0fd6ab9d284b5c6e7f37).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    **[Test build #3889 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3889/testReport)** for PR 18923 at commit [`bd521e0`](https://github.com/apache/spark/commit/bd521e0f4b3b583e182b0fd6ab9d284b5c6e7f37).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with large in...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/18923
  
    Ping @maasg do you have time to address my comment?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18923: [SPARK-21710][StSt] Fix OOM on ConsoleSink with l...

Posted by maasg <gi...@git.apache.org>.
Github user maasg closed the pull request at:

    https://github.com/apache/spark/pull/18923


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org