You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/11 22:41:35 UTC
[GitHub] [kafka] cmccabe opened a new pull request #9866: KAFKA-12180: Implement the KIP-631 message generator changes
cmccabe opened a new pull request #9866:
URL: https://github.com/apache/kafka/pull/9866
* Implement the uint16 type
* Implement MetadataRecordType and MetadataJsonConverters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #9866: KAFKA-12180: Implement the KIP-631 message generator changes
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #9866:
URL: https://github.com/apache/kafka/pull/9866#discussion_r556074024
##########
File path: generator/src/main/java/org/apache/kafka/message/MessageSpecType.java
##########
@@ -30,5 +30,8 @@
HEADER,
@JsonProperty("data")
- DATA;
+ DATA,
+
+ @JsonProperty("metadata")
Review comment:
I added a comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe closed pull request #9866: KAFKA-12180: Implement the KIP-631 message generator changes
Posted by GitBox <gi...@apache.org>.
cmccabe closed pull request #9866:
URL: https://github.com/apache/kafka/pull/9866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #9866: KAFKA-12180: Implement the KIP-631 message generator changes
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #9866:
URL: https://github.com/apache/kafka/pull/9866#discussion_r556071794
##########
File path: generator/src/main/java/org/apache/kafka/message/MessageSpecType.java
##########
@@ -30,5 +30,8 @@
HEADER,
@JsonProperty("data")
- DATA;
+ DATA,
+
+ @JsonProperty("metadata")
Review comment:
Might be helpful to have a short description here (or somewhere else if you can think of a better location) which explains that this type is reserved for the controller record types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9866: KAFKA-12180: Implement the KIP-631 message generator changes
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9866:
URL: https://github.com/apache/kafka/pull/9866#issuecomment-758959674
merged, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org