You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/09/21 15:04:00 UTC

[jira] [Work logged] (HIVE-26543) Improve TxnHandler, TxnUtils, CompactionTxnHandler logging

     [ https://issues.apache.org/jira/browse/HIVE-26543?focusedWorklogId=810818&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810818 ]

ASF GitHub Bot logged work on HIVE-26543:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/22 15:03
            Start Date: 21/Sep/22 15:03
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on PR #3603:
URL: https://github.com/apache/hive/pull/3603#issuecomment-1253840591

   thanks @achennagiri and @zabetak, I addressed your comments in https://github.com/apache/hive/pull/3603/commits/4634139b69b2ee652cc368659242741bef1c6603




Issue Time Tracking
-------------------

    Worklog Id:     (was: 810818)
    Time Spent: 1h 50m  (was: 1h 40m)

> Improve TxnHandler, TxnUtils, CompactionTxnHandler logging
> ----------------------------------------------------------
>
>                 Key: HIVE-26543
>                 URL: https://issues.apache.org/jira/browse/HIVE-26543
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> TxnHandler has some bad logging, like:
> {code}
> LOG.debug("Going to execute query<" + txnsQuery + ">");
> {code}
> https://github.com/apache/hive/blob/8e39937bdb577bc135579d7d34b46ba2d788ca53/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L533
> this will involve a pretty unnecessary string concatenation in production when we're on INFO level usually, let's use string formats



--
This message was sent by Atlassian Jira
(v8.20.10#820010)