You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by jk...@apache.org on 2007/01/26 03:16:44 UTC

svn commit: r500100 - /incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java

Author: jkaputin
Date: Thu Jan 25 18:16:43 2007
New Revision: 500100

URL: http://svn.apache.org/viewvc?view=rev&rev=500100
Log:
WODEN-10 Fixed potential NPE by checking if an
Element was retrieved for the specified fragid.

Modified:
    incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java

Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java?view=diff&rev=500100&r1=500099&r2=500100
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/resolver/DOMSchemaResolverAdapter.java Thu Jan 25 18:16:43 2007
@@ -27,7 +27,6 @@
 import org.apache.xml.serialize.XMLSerializer;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
-import org.xml.sax.InputSource;
 
 /**
  * Class that adds DOM specific behaviour to the SchemaResolverAdapter class.
@@ -51,9 +50,16 @@
         String id = fragId.substring(1);
         Element schemaEl = doc.getElementById(id);
         
+        if(schemaEl == null) {
+            //the fragid does not identify any element
+            //TODO suitable error message
+            return null;
+        }
+        
         String localName = schemaEl.getLocalName();
         if(!localName.equals("schema")) {
-            //the fragId does not point to a schema element
+            //the fragid does not point to a schema element
+            //TODO suitable error message
             return null;
         }
         



---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org