[jira] Commented: (JAMES-509) Cleanup/Refactor FetchMail code

["Joachim Draeger (JIRA)" <se...@james.apache.org>]

    [ http://issues.apache.org/jira/browse/JAMES-509?page=comments#action_12418409 ] 

Joachim Draeger commented on JAMES-509:
---------------------------------------

Shame on me. To less sleep last night. Don't know why I've attached it to the wrong issue. Any way to revoke it?

> Cleanup/Refactor FetchMail code
> -------------------------------
>
>          Key: JAMES-509
>          URL: http://issues.apache.org/jira/browse/JAMES-509
>      Project: James
>         Type: Improvement

>   Components: FetchMail
>     Versions: 2.4.0
>     Reporter: Stefano Bagnara
>     Assignee: Stefano Bagnara
>      Fix For: 2.4.0
>  Attachments: fetchmail-refactoring1, fetchmail-refactoring2, james-imap2-proposal-extended-2.zip
>
> Current FetchMail code is really hard to read and manage.
> I loose too much time looking around its code to understand how things works.
> So I put my hands in, and applied a few refactoring.
> I already removed 2200 lines of code (50Kbytes of code) while keeping the same functionality (only refactorings).
> Of course refactorings like this are not always an easy change: I also remove the StoreProcessor/FolderProcessor/MessageProcessor granular creation by refactoring them to top level reentrant objects that take things to process as arguments to their "process" method.
> MessageProcessor is still a mess, but I think this is more selfdocumenting than before.
> I can clean up things much more and update documentation and so on, but I would like to know if this kind of update is welcome or not, before loosing too much time.
> Stefano

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org