[jira] [Created] (MESOS-8602) Subscribers::send incorrectly assumes frameworks are registered

["Yan Xu (JIRA)" <ji...@apache.org>]

Yan Xu created MESOS-8602:
-----------------------------

             Summary: Subscribers::send incorrectly assumes frameworks are registered
                 Key: MESOS-8602
                 URL: https://issues.apache.org/jira/browse/MESOS-8602
             Project: Mesos
          Issue Type: Bug
            Reporter: Yan Xu


We observed this in prod
{noformat}
F0214 00:36:15.746939 3827787 master.cpp:11190] Check failed: 'framework' Must be non NULL
{noformat}
which is here in code: [https://github.com/apache/mesos/blob/9635d4a2d12fc77935c3d5d166469258634c6b7e/src/master/master.cpp#L11203]
h2. Diagnosis

The checks were added in in [https://github.com/apache/mesos/commit/cf331184714f692f21988a53fd04fa64fbbb3aba] MESOS-8469, 
{code:java}
Framework* framework =
master->getFramework(event.task_added().task().framework_id());

CHECK_NOTNULL(framework);
{code}
However as least when we recover tasks when the agent reregisters after a master failover, the frameworks may not have reregistered yet so they don't show up in the result from {{master->getFramework}}. Such checks failed to consider this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)