You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 21:55:41 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow

nealrichardson commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r500617928



##########
File path: dev/tasks/conda-recipes/r-arrow/configure.win
##########
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+set -euxo pipefail
+
+echo "PKG_CPPFLAGS=-DNDEBUG -I\"${LIBRARY_PREFIX}/include\" -I\"${PREFIX}/include\" -DARROW_R_WITH_ARROW" > src/Makevars.win

Review comment:
       assuming arrow-cpp is built with `ARROW_S3=ON`, do this:
   
   ```suggestion
   echo "PKG_CPPFLAGS=-DNDEBUG -I\"${LIBRARY_PREFIX}/include\" -I\"${PREFIX}/include\" -DARROW_R_WITH_ARROW -DARROW_R_WITH_S3" > src/Makevars.win
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org