You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/01 16:51:04 UTC
[jira] [Commented] (SAMZA-1214) Allow users to set a default
replication.factor for intermediate topics.
[ https://issues.apache.org/jira/browse/SAMZA-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991075#comment-15991075 ]
ASF GitHub Bot commented on SAMZA-1214:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/150
SAMZA-1214: Bug - system-scoped stream default configs may not be honored
* Re-introduced deprecated system-stream configs into config table
* Fixed position of task.consumer.batch.size in config table
* Moved system-scoped defaults from StreamConfig to SystemConfig
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza samza-1214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #150
----
commit d2d924ae2410562830b0d21a9077165f9cf51d12
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-04-26T19:32:18Z
SAMZA-1214: Allow users to set a default replication.factor for intermediate topics
commit 80cd86f428c0df4be07300f0882679baf752423a
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-04-26T19:37:04Z
Merge remote-tracking branch 'upstream/master'
commit 7ecb4b8c725a4d42c94a4378e83ed0340a24ffd6
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-04-26T19:58:53Z
Some cleanup after looking at the PR
commit 87c68c4682b1983477b56c522642c99c42447740
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-04-26T20:25:47Z
Adding one more test to verify that the defaults and overrides work from the StreamSpec perspective
commit fe7200b7adf1c6d4d1d9f8cacbb7dfb096c60cea
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-04-27T16:46:02Z
Address review feedback
commit 8cdcd4e6c587db23e85dcff8e8d9dbf9cdd0967b
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-05-01T16:48:03Z
SAMZA-1214: Bug - system-scoped stream default configs may not be honored.
----
> Allow users to set a default replication.factor for intermediate topics.
> ------------------------------------------------------------------------
>
> Key: SAMZA-1214
> URL: https://issues.apache.org/jira/browse/SAMZA-1214
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
> Fix For: 0.13.0
>
>
> For auto-topic creation, samza uses a default replication factor of 2. However, this default doesn't not work in simple demo scenarios like the local, single-broker kafka we deploy using the "grid" script.
> To get around this, users need a way to set the replication factor.
> The new config allows it to be set as follows
> {noFormat}
> streams.[streamId].replication.factor
> {noFormat}
> but since intermediate streams are autogenerated, the user doesn't know the streamId.
> We need a way for users to set the default replication factor for all streams.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)