You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/01/12 01:28:30 UTC
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5687
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017)
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017)
* Copy gutil from Kudu@c6fcede (10/1/2017)
* Change includes to remove kudu/ prefix and KUDU_ guard prefix
* Minimal changes to gutil/CMakeLists.txt
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
90 files changed, 8,948 insertions(+), 3,846 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5687/1
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 5: Code-Review+1
I did a quick pass over the changes and it looks like the changes are either in bits of gutil we don't use or very minor.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 7:
(4 comments)
Do you know if kudu actually pulled in a newer version of this code from upstream, and if so, which version?
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/bits.cc
File be/src/gutil/bits.cc:
Line 88: }
why did these move from the header?
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/gscoped_ptr.h
File be/src/gutil/gscoped_ptr.h:
PS7, Line 112: kudu
is that intentional?
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/port.h
File be/src/gutil/port.h:
PS7, Line 939: kudu
is that expected?
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/walltime.h
File be/src/gutil/walltime.h:
PS7, Line 83: 1e6
we had intentionally changed these so that we'd be using integer operations rather than floating point. can we cherry pick that commit back over?
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5687
to look at the new patch set (#8).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Minimal changes to gutil/CMakeLists.txt
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
M be/src/gutil/atomicops.h
M be/src/gutil/auxiliary/atomicops-internals-arm-generic.h
M be/src/gutil/auxiliary/atomicops-internals-arm-v6plus.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
M be/src/gutil/auxiliary/atomicops-internals-windows.h
M be/src/gutil/basictypes.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/builtin_type_hash.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/city.h
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/hash128to64.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/jenkins.h
M be/src/gutil/hash/jenkins_lookup2.h
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/hash/string_hash.h
M be/src/gutil/int128.cc
M be/src/gutil/int128.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/manual_constructor.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/once.h
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock.cc
M be/src/gutil/spinlock.h
M be/src/gutil/spinlock_internal.cc
M be/src/gutil/spinlock_internal.h
M be/src/gutil/spinlock_linux-inl.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/stringprintf.h
M be/src/gutil/strings/ascii_ctype.cc
M be/src/gutil/strings/charset.cc
M be/src/gutil/strings/charset.h
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/fastmem.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/human_readable.h
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/memutil.h
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/strip.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/strtoint.cc
M be/src/gutil/strtoint.h
M be/src/gutil/synchronization_profiling.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
122 files changed, 9,196 insertions(+), 4,102 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5687/8
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 8: Verified+1
Validated as part of this GVO:
http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/420/
Note that https://gerrit.cloudera.org/#/c/5688/ is required for this change to compile, so I'm submitting them together.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 4:
(2 comments)
Looks like this accidentally reverted some deliberate changes we made. Otherwise looks fine.
http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/atomicops-internals-x86.h
File be/src/gutil/atomicops-internals-x86.h:
Line 46: bool has_amd_lock_mb_bug; // Processor has AMD memory-barrier bug; do lfence
This code was deliberately removed in
commit a7c3f301bb1da14d6bb35d37aab47450c67cca0c
Author: Dan Hecht <dh...@cloudera.com>
Date: Wed Mar 9 14:34:10 2016 -0800
Remove AMD Opteron Rev E workaround from atomicops
http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/bits.h
File be/src/gutil/bits.h:
Line 141
It looks you reverted:
commit 92fafa1c0687141481e56ea6f09a67987d571d6e
Author: Tim Armstrong <ta...@cloudera.com>
Date: Fri Apr 8 10:23:03 2016 -0700
Use more efficient gutil implementation of Log2Ceiling
I think you mentioned that something changed here to me in person but I misunderstood what the actual change was. If we want to avoid future conflicts we could just add the optimised version to our BitUtil and switch over the users.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/atomicops-internals-x86.h
File be/src/gutil/atomicops-internals-x86.h:
Line 46: bool has_amd_lock_mb_bug; // Processor has AMD memory-barrier bug; do lfence
> This code was deliberately removed in
Thanks, reinstated.
http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/bits.h
File be/src/gutil/bits.h:
Line 141
> It looks you reverted:
Ok - I added those methods to BitUtil so that they're less likely to get overwritten in the future. Those changes are in the 2/2 commit.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Minimal changes to gutil/CMakeLists.txt
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Reviewed-on: http://gerrit.cloudera.org:8080/5687
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Henry Robinson <he...@cloudera.com>
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
M be/src/gutil/atomicops.h
M be/src/gutil/auxiliary/atomicops-internals-arm-generic.h
M be/src/gutil/auxiliary/atomicops-internals-arm-v6plus.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
M be/src/gutil/auxiliary/atomicops-internals-windows.h
M be/src/gutil/basictypes.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/builtin_type_hash.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/city.h
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/hash128to64.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/jenkins.h
M be/src/gutil/hash/jenkins_lookup2.h
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/hash/string_hash.h
M be/src/gutil/int128.cc
M be/src/gutil/int128.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/manual_constructor.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/once.h
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock.cc
M be/src/gutil/spinlock.h
M be/src/gutil/spinlock_internal.cc
M be/src/gutil/spinlock_internal.h
M be/src/gutil/spinlock_linux-inl.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/stringprintf.h
M be/src/gutil/strings/ascii_ctype.cc
M be/src/gutil/strings/charset.cc
M be/src/gutil/strings/charset.h
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/fastmem.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/human_readable.h
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/memutil.h
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/strip.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/strtoint.cc
M be/src/gutil/strtoint.h
M be/src/gutil/synchronization_profiling.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
122 files changed, 9,196 insertions(+), 4,102 deletions(-)
Approvals:
Henry Robinson: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 7:
(4 comments)
I don't think there's a new upstream version of this code in Kudu (which comes from https://chromium.googlesource.com/chromium/src/base/). But they made some local changes that were necessary to keep the kudu library dependencies compiling.
I think having gutil as a toolchain dependency might make some sense in the future, so that it's easier to replay the patches we want if we ever upgrade the base code.
For now, I've split the two commits a bit better: this commit only imports the code (and touches CMakeLists.txt). The following commit makes all the code changes required to have it compile. That way only that commit needs to be checked in the future if we have to do this again.
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/bits.cc
File be/src/gutil/bits.cc:
Line 88: }
> why did these move from the header?
I moved our implementation into our BitUtil class. These went back to the .cc file where they were originally.
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/gscoped_ptr.h
File be/src/gutil/gscoped_ptr.h:
PS7, Line 112: kudu
> is that intentional?
It happened in this kudu commit:
https://github.com/apache/kudu/commit/bb6da1946ea90e3b64bb7a38d9e5751cc95c557b
"gutil: move classes used by exported client into kudu namespace"
To me it's unfortunate but benign. Since the kutil libraries use these classes (much more than we do), we'd have to change the namespacing either here or there. I think, but am prepared to be convinced otherwise, that it's better to have as few changes to these bulk imports as possible.
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/port.h
File be/src/gutil/port.h:
PS7, Line 939: kudu
> is that expected?
Came with the bulk-import. Since it's commented out, I didn't investigate too deeply (again, it's a place where fidelity to the source probably outweighs cleanliness concerns).
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/walltime.h
File be/src/gutil/walltime.h:
PS7, Line 83: 1e6
> we had intentionally changed these so that we'd be using integer operations
Done.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5687
to look at the new patch set (#6).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Change includes to remove kudu/ prefix and KUDU_ guard prefix
* Minimal changes to gutil/CMakeLists.txt
* Include cherry-pick of 0c0b6f7 "Remove AMD Opteron Rev E workaround
from atomicops".
* Overwrite changes from 92fafa "Use more efficient gutil implementation
of Log2Ceiling" in favour of implementing them in Impala code only.
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
90 files changed, 8,901 insertions(+), 3,837 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5687/6
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
> (4 comments)
>
> I don't think there's a new upstream version of this code in Kudu
> (which comes from https://chromium.googlesource.com/chromium/src/base/).
> But they made some local changes that were necessary to keep the
> kudu library dependencies compiling.
>
Okay. I wasn't sure given some of the large deletions (like sparsetable.h). So you're saying that kudu deleted that code from their gutils, it wasn't deleted upstream).
> I think having gutil as a toolchain dependency might make some
> sense in the future, so that it's easier to replay the patches we
> want if we ever upgrade the base code.
>
> For now, I've split the two commits a bit better: this commit only
> imports the code (and touches CMakeLists.txt). The following commit
> makes all the code changes required to have it compile. That way
> only that commit needs to be checked in the future if we have to do
> this again.
Okay, let me take a quick look at the second patch again given some code has moved between them.
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/gscoped_ptr.h
File be/src/gutil/gscoped_ptr.h:
PS7, Line 112: kudu
> It happened in this kudu commit:
It's just surprising to impala developers to see this, if they don't know this full history. you'd ask yourself, "what does this code have to do with kudu?" and the answer is "nothing".
I'm fine with leaving it, just wasn't sure what was going on with it.
http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/port.h
File be/src/gutil/port.h:
PS7, Line 939: kudu
> Came with the bulk-import. Since it's commented out, I didn't investigate t
okay. similar to kudu namespace, this is just another thing that will be confusing to impala developers, but given how remote the code is, i'm not overly concerned. mainly just wanted to verify there wasn't a botched merge here or something.
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
Patch Set 6:
Also fixes IMPALA-5116
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Change includes to remove kudu/ prefix and KUDU_ guard prefix
* Minimal changes to gutil/CMakeLists.txt
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
90 files changed, 8,948 insertions(+), 3,854 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5687/4
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#5).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Change includes to remove kudu/ prefix and KUDU_ guard prefix
* Minimal changes to gutil/CMakeLists.txt
* Include cherry-pick of 0c0b6f7 "Remove AMD Opteron Rev E workaround
from atomicops".
* Overwrite changes from 92fafa "Use more efficient gutil implementation
of Log2Ceiling" in favour of implementing them in Impala code only.
Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
---
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/callback_internal.cc
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/cpu.cc
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/once.cc
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/types.pb.cc
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/ref_counted.cc
A be/src/gutil/ref_counted.h
A be/src/gutil/ref_counted_memory.cc
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/thread_collision_warner.cc
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
90 files changed, 8,905 insertions(+), 3,853 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5687/5
--
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>