You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "OmCheeLin (via GitHub)" <gi...@apache.org> on 2025/08/11 01:40:30 UTC
[PR] Login with username and password [skywalking-banyandb-java-client]
OmCheeLin opened a new pull request, #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89
Add `AuthInterceptor` to support login with username and password.
Test: `BanyanDBAuthTest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2271807245
##########
README.md:
##########
@@ -41,6 +41,10 @@ options are listed below,
| forceReconnectionThreshold | Threshold of force gRPC reconnection if network issue is encountered | 1 |
| forceTLS | Force use TLS for gRPC | false |
| sslTrustCAPath | SSL: Trusted CA Path | |
+| sslCertChainPath | SSL: Cert Chain Path, BanyanDB server not support mTLS yet | |
+| sslKeyPath | SSL: Cert Key Path, BanyanDB server not support mTLS yet | |
Review Comment:
The first commit is copying server-side TLS-related options here. Didn't realize the client only needs trustCA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2265554564
##########
src/test/java/org/apache/skywalking/banyandb/v1/client/BanyanDBAuthTest.java:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client;
+
+import org.apache.skywalking.banyandb.common.v1.BanyandbCommon;
+import org.apache.skywalking.banyandb.v1.client.grpc.exception.UnauthenticatedException;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.wait.strategy.Wait;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.MountableFile;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.attribute.PosixFilePermissions;
+import java.util.Base64;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import static org.awaitility.Awaitility.await;
+import static org.junit.Assert.assertThrows;
+
+public class BanyanDBAuthTest {
+ private static final String REGISTRY = "ghcr.io";
+ private static final String IMAGE_NAME = "apache/skywalking-banyandb";
+ private static final String TAG = "42ec9df7457868926eb80157b36355d94fcd6bba";
+
+ private static final String IMAGE = REGISTRY + "/" + IMAGE_NAME + ":" + TAG;
+
+ protected static final int GRPC_PORT = 17912;
+ protected static final int HTTP_PORT = 17913;
+
+ @Rule
+ public GenericContainer<?> banyanDB;
+
+ public BanyanDBAuthTest() throws Exception {
+ // Step 1: prepare config file with 0600 permissions
+ Path tempConfigPath = Files.createTempFile("bydb_server_config", ".yaml");
+ Files.write(tempConfigPath, Files.readAllBytes(
+ Paths.get(getClass().getClassLoader().getResource("config.yaml").toURI()))
+ );
+ Files.setPosixFilePermissions(tempConfigPath, PosixFilePermissions.fromString("rw-------"));
+
+ // Step 2: create container
+ banyanDB = new GenericContainer<>(DockerImageName.parse(IMAGE))
+ .withCopyFileToContainer(
+ MountableFile.forHostPath(tempConfigPath),
+ "/tmp/bydb_server_config.yaml"
+ )
+ .withCommand("standalone",
+ "--auth-config-file", "/tmp/bydb_server_config.yaml",
+ "--enable-health-auth", "true"
Review Comment:
I think we don't need this for the health check API, even in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2265542758
##########
src/test/java/org/apache/skywalking/banyandb/v1/client/BanyanDBAuthTest.java:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client;
+
+import org.apache.skywalking.banyandb.common.v1.BanyandbCommon;
+import org.apache.skywalking.banyandb.v1.client.grpc.exception.UnauthenticatedException;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.wait.strategy.Wait;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.MountableFile;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.attribute.PosixFilePermissions;
+import java.util.Base64;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import static org.awaitility.Awaitility.await;
+import static org.junit.Assert.assertThrows;
+
+public class BanyanDBAuthTest {
Review Comment:
```suggestion
public class ITBanyanDBAuthTest {
```
I think IT prefix is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2265543268
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/auth/AuthInterceptor.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client.auth;
+
+import io.grpc.CallOptions;
+import io.grpc.Channel;
+import io.grpc.ClientCall;
+import io.grpc.ClientInterceptor;
+import io.grpc.ForwardingClientCall;
+import io.grpc.Metadata;
+import io.grpc.MethodDescriptor;
+
+public class AuthInterceptor implements ClientInterceptor {
+ private final String username;
+ private final String password;
+
+ public AuthInterceptor(String username, String password) {
+ this.username = username;
+ this.password = password;
+ }
+
+ @Override
+ public <REQ_T, RESP_T> ClientCall<REQ_T, RESP_T> interceptCall(
+ MethodDescriptor<REQ_T, RESP_T> method,
+ CallOptions callOptions,
+ Channel next) {
+
+ return new ForwardingClientCall.SimpleForwardingClientCall<REQ_T, RESP_T>(
+ next.newCall(method, callOptions)) {
+ @Override
+ public void start(Listener<RESP_T> responseListener, Metadata headers) {
+ Metadata.Key<String> usernameKey = Metadata.Key.of("username", Metadata.ASCII_STRING_MARSHALLER);
+ Metadata.Key<String> passwordKey = Metadata.Key.of("password", Metadata.ASCII_STRING_MARSHALLER);
+
+ headers.put(usernameKey, username);
+ headers.put(passwordKey, password);
+
Review Comment:
Creating metadata keys on every request is inefficient. Consider declaring these as static final fields to avoid repeated object creation.
```suggestion
headers.put(USERNAME_KEY, username);
headers.put(PASSWORD_KEY, password);
```
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/auth/AuthInterceptor.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client.auth;
+
+import io.grpc.CallOptions;
+import io.grpc.Channel;
+import io.grpc.ClientCall;
+import io.grpc.ClientInterceptor;
+import io.grpc.ForwardingClientCall;
+import io.grpc.Metadata;
+import io.grpc.MethodDescriptor;
+
+public class AuthInterceptor implements ClientInterceptor {
+ private final String username;
+ private final String password;
+
+ public AuthInterceptor(String username, String password) {
+ this.username = username;
+ this.password = password;
+ }
+
+ @Override
+ public <REQ_T, RESP_T> ClientCall<REQ_T, RESP_T> interceptCall(
+ MethodDescriptor<REQ_T, RESP_T> method,
+ CallOptions callOptions,
+ Channel next) {
+
+ return new ForwardingClientCall.SimpleForwardingClientCall<REQ_T, RESP_T>(
+ next.newCall(method, callOptions)) {
+ @Override
+ public void start(Listener<RESP_T> responseListener, Metadata headers) {
+ Metadata.Key<String> usernameKey = Metadata.Key.of("username", Metadata.ASCII_STRING_MARSHALLER);
+ Metadata.Key<String> passwordKey = Metadata.Key.of("password", Metadata.ASCII_STRING_MARSHALLER);
+
+ headers.put(usernameKey, username);
+ headers.put(passwordKey, password);
+
Review Comment:
Creating metadata keys on every request is inefficient. Consider declaring these as static final fields to avoid repeated object creation.
```suggestion
headers.put(USERNAME_KEY, username);
headers.put(PASSWORD_KEY, password);
```
##########
src/test/resources/config.yaml:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+users:
+ - username: admin
+ password: 123456
+ - username: test
+ password: 123456
Review Comment:
Using weak passwords like '123456' in test configuration poses security risks if accidentally used in production. Consider using stronger test passwords or environment-specific configuration.
```suggestion
password: S3cureP@ssw0rd!Admin
- username: test
password: T3stP@ssw0rd!2024
```
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -183,8 +185,18 @@ public void connect() throws IOException {
for (int i = 0; i < this.targets.length; i++) {
addresses[i] = URI.create("//" + this.targets[i]);
}
- this.channel = ChannelManager.create(this.options.buildChannelManagerSettings(),
+ Channel rawChannel = ChannelManager.create(this.options.buildChannelManagerSettings(),
new DefaultChannelFactory(addresses, this.options));
+ Channel interceptedChannel = rawChannel;
+ // register auth interceptor
+ String username = options.getUsername();
+ String password = options.getPassword();
+ if (!"".equals(username) && !"".equals(password)) {
+ interceptedChannel = ClientInterceptors.intercept(rawChannel,
+ new AuthInterceptor(options.getUsername(), options.getPassword()));
Review Comment:
[nitpick] The username and password are retrieved twice - once for the condition check and again for the interceptor constructor. Consider storing them in local variables to improve readability and avoid duplicate method calls.
```suggestion
new AuthInterceptor(username, password));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2268512256
##########
README.md:
##########
@@ -41,6 +41,10 @@ options are listed below,
| forceReconnectionThreshold | Threshold of force gRPC reconnection if network issue is encountered | 1 |
| forceTLS | Force use TLS for gRPC | false |
| sslTrustCAPath | SSL: Trusted CA Path | |
+| sslCertChainPath | SSL: Cert Chain Path, BanyanDB server not support mTLS yet | |
+| sslKeyPath | SSL: Cert Key Path, BanyanDB server not support mTLS yet | |
Review Comment:
Why don't support in server side, but exist in client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2268510929
##########
README.md:
##########
@@ -41,6 +41,10 @@ options are listed below,
| forceReconnectionThreshold | Threshold of force gRPC reconnection if network issue is encountered | 1 |
| forceTLS | Force use TLS for gRPC | false |
| sslTrustCAPath | SSL: Trusted CA Path | |
+| sslCertChainPath | SSL: Cert Chain Path, BanyanDB server not support mTLS yet | |
+| sslKeyPath | SSL: Cert Key Path, BanyanDB server not support mTLS yet | |
Review Comment:
I prefer to remove them since the server side doesn't support mTLS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2271811319
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/Options.java:
##########
@@ -63,6 +63,14 @@ public class Options {
* SSL: Cert Key Path, BanyanDB server not support mTLS yet
*/
private String sslKeyPath = "";
Review Comment:
Indeed. The initial commit of this file introduced it. Thanks to @wankai123, he indicated that "BanyanDB server does not support mTLS yet," which led me to understand that the client does not require them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2271875821
##########
README.md:
##########
@@ -41,6 +41,10 @@ options are listed below,
| forceReconnectionThreshold | Threshold of force gRPC reconnection if network issue is encountered | 1 |
| forceTLS | Force use TLS for gRPC | false |
| sslTrustCAPath | SSL: Trusted CA Path | |
+| sslCertChainPath | SSL: Cert Chain Path, BanyanDB server not support mTLS yet | |
+| sslKeyPath | SSL: Cert Key Path, BanyanDB server not support mTLS yet | |
Review Comment:
I fixed it by #90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#issuecomment-3173417213
Please update the readme doc about this new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2265551564
##########
src/test/java/org/apache/skywalking/banyandb/v1/client/BanyanDBAuthTest.java:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client;
+
+import org.apache.skywalking.banyandb.common.v1.BanyandbCommon;
+import org.apache.skywalking.banyandb.v1.client.grpc.exception.UnauthenticatedException;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.wait.strategy.Wait;
+import org.testcontainers.utility.DockerImageName;
+import org.testcontainers.utility.MountableFile;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.attribute.PosixFilePermissions;
+import java.util.Base64;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import static org.awaitility.Awaitility.await;
+import static org.junit.Assert.assertThrows;
+
+public class BanyanDBAuthTest {
+ private static final String REGISTRY = "ghcr.io";
+ private static final String IMAGE_NAME = "apache/skywalking-banyandb";
+ private static final String TAG = "42ec9df7457868926eb80157b36355d94fcd6bba";
+
+ private static final String IMAGE = REGISTRY + "/" + IMAGE_NAME + ":" + TAG;
+
+ protected static final int GRPC_PORT = 17912;
+ protected static final int HTTP_PORT = 17913;
+
+ @Rule
+ public GenericContainer<?> banyanDB;
+
+ public BanyanDBAuthTest() throws Exception {
+ // Step 1: prepare config file with 0600 permissions
+ Path tempConfigPath = Files.createTempFile("bydb_server_config", ".yaml");
+ Files.write(tempConfigPath, Files.readAllBytes(
+ Paths.get(getClass().getClassLoader().getResource("config.yaml").toURI()))
+ );
+ Files.setPosixFilePermissions(tempConfigPath, PosixFilePermissions.fromString("rw-------"));
+
+ // Step 2: create container
+ banyanDB = new GenericContainer<>(DockerImageName.parse(IMAGE))
+ .withCopyFileToContainer(
+ MountableFile.forHostPath(tempConfigPath),
+ "/tmp/bydb_server_config.yaml"
+ )
+ .withCommand("standalone",
+ "--auth-config-file", "/tmp/bydb_server_config.yaml",
+ "--enable-health-auth", "true"
Review Comment:
what is the `--enable-health-auth` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2265563820
##########
src/test/resources/config.yaml:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+users:
+ - username: admin
+ password: 123456
+ - username: test
+ password: 123456
Review Comment:
This is just a mock password. Ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Login with username and password [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #89:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/89#discussion_r2268512652
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/Options.java:
##########
@@ -63,6 +63,14 @@ public class Options {
* SSL: Cert Key Path, BanyanDB server not support mTLS yet
*/
private String sslKeyPath = "";
Review Comment:
@hanahmily This code seems existing before this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org