You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2018/03/20 12:57:49 UTC

[GitHub] flink pull request #5729: [FLINK-7343][kafka-tests] Fix test at-least-once t...

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/5729

    [FLINK-7343][kafka-tests] Fix test at-least-once test instability

    This pr fixes instabilities in both Kafka 0.10 and Kafka 0.9.
    
    Previously we could set lastSnapshotedElement to some value during checkpointing AFTER executing shutdown while KafkaProducer snapshot of this value would fail. This was leading to incorrectly expect this value to be present in the test kafka topic. Fix is to remember lastSnapshotedElementBeforeShutdown - last snapshot that we exepct to succeed without failure.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink f7343

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5729.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5729
    
----

----


---

[GitHub] flink issue #5729: [FLINK-7343][kafka-tests] Fix test at-least-once test ins...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5729
  
    merging.


---

[GitHub] flink issue #5729: [FLINK-7343][kafka-tests] Fix test at-least-once test ins...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5729
  
    Sweet, nice to see this fixed.
    
    Code looks good, +1 to merge!


---

[GitHub] flink pull request #5729: [FLINK-7343][kafka-tests] Fix test at-least-once t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5729


---

[GitHub] flink issue #5729: [FLINK-7343][kafka-tests] Fix test at-least-once test ins...

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/5729
  
    Thanks!


---